[Bug 902086] Review request: Elasticsearch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=902086



--- Comment #137 from jiri vanek <jvanek@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #136)
> - There's no such thing as systmed-units. Please remove BR:systemd-units.
will be fixed ( I thought it was)
> - I think you might want to remove printing of the jar list in the wrapper
> script. It is rather long and ends up in the logs.
will be fixed ( I forgot -x in it)
> - Putting the configuration in /var/lib/ is a bit nonstandard. It would be
> better to
> move it to /etc/elasticsearch and provide a symlink
> /var/lib/elasticsearch/conf → /etc/elasticsearch

Yah, I thought you will not like it. I will put it into etc and link.
> if necessary.

Yes it will be.


> availability, sociability, implacability
> elasticsearch.noarch: E: executable-marked-as-config-file
> /var/lib/elasticsearch/conf/elasticsearch.yml
> elasticsearch.noarch: E: script-without-shebang
> /var/lib/elasticsearch/conf/elasticsearch.yml
> elasticsearch.noarch: E: executable-marked-as-config-file
> /var/lib/elasticsearch/conf/logging.yml
> elasticsearch.noarch: E: script-without-shebang
> /var/lib/elasticsearch/conf/logging.yml
> Bogus errors.

Crap, how did they sneeked in? I will move them to 644 and by that they will be
fixed agin.
> 
>

Is there something more you need me to do?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]