https://bugzilla.redhat.com/show_bug.cgi?id=1194628 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #2) > (In reply to Petr Šabata from comment #1) > > Note: All the patched files are read-only. I assume the patching could > > fail, even though it currently doesn't. Perhaps making them writable before > > patching would be a good idea. > > > I added this write permissions to the spec file. Updated package is on the > same address. Ack. > > Ad Patch1 -- according to Web Assets guidelines, Fedora webservers provide > > %{_webassetdir} in `/_sysassets', not `/.sysassets'. Please, correct the > > patch. > > > This was a bug in guidelines and has been already corrected > <https://fedoraproject.org/w/index. > php?title=Packaging%3AWeb_Assets&action=historysubmit&diff=404471&oldid=35029 > 3>. The name with the dot is correct one. Fair enough. > > Consider bumping the minimum required version of EU::MM to 6.76 and using > > NO_PACKLIST to simplify the SPEC. > > > > The convert.t test doesn't actually convert anything. Maybe you could > > enhance it a bit? However, that's beyond the scope of this review. > > I'm not much interested in this. Okay then. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review