https://bugzilla.redhat.com/show_bug.cgi?id=1188093 --- Comment #17 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- As mentioned: 1. MUST fix Licensing: NOT ok In addition to MIT licensed stuff, we have libqtile/widget/pacman.py:GPL (v3 or later) libqtile/widget/google_calendar.py:Apache (v2.0) So, I'd suggest using something like: # All MIT except for: # libqtile/widget/pacman.py:GPL (v3 or later) # libqtile/widget/google_calendar.py:Apache (v2.0) License: MIT and GPLv3+ and ASL 2.0 2. SHOULD replace %files ... %{_mandir}/man1/qsh.1.gz %{_mandir}/man1/qtile.1.gz with %{_mandir}/man1/qsh.1* %{_mandir}/man1/qtile.1* 3. SHOULD simplify %files I *think* there's some redundancy, %{python2_sitelib}/qtile-%{version}-py%{python2_version}.egg-info %{python2_sitelib}/qtile-%{version}-py%{python2_version}.egg-info/* %{python2_sitelib}/libqtile %{python2_sitelib}/libqtile/* can be replaced with %{python2_sitelib}/qtile-%{version}-py%{python2_version}.egg-info/ %{python2_sitelib}/libqtile/ (including directories implies including everything recursively under it too) So, all I see is 1 MUST blocker (so far), the licensing. fix that, and we should be good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review