https://bugzilla.redhat.com/show_bug.cgi?id=1193990 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@xxxxxxxxxx --- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> --- (In reply to nobrakal from comment #0) > > Tinyxml and tinyxpath seems to be bundled libraries, but there is nothing > about it in readme, copying or authors files... I don't know what to do. There is some info inside the source files: binreloc: the official homepage not valid anymore, although there are many copies; it is not needed for Fedora, maybe it could be patched out? (from configure.ac, and using stubs for br_find_* function in zen.cpp and main.cpp files?) tinyxml: http://sourceforge.net/projects/tinyxml/ - this is already packaged in Fedora tinyxpath: http://sourceforge.net/projects/tinyxpath/ - needs to be packaged Btw. they have also different licenses, but it will be solved by unbundling. More comments to the packaging: 1) it is better to not using dropbox: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Upload_Your_Package 2) license file is missing in the package (COPYING file) 3) what does the empty '%doc'? 4) it could be added '%config(noreplace)' to '%{_sysconfdir}/%{name}' 5) man pages should be installed uncomplessed and leave to the build system thier compression (http://fedoraproject.org/wiki/Packaging:Guidelines#Manpages) 6) details: - it may be easier to remove INSTALL* files or using %exclude instead of patching, but using patch is OK - the commented out 'Requires:' line can be removed - you can consider noarch subpackage (opencity-data?) for /usr/share/opencity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review