https://bugzilla.redhat.com/show_bug.cgi?id=665733 --- Comment #28 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Ok, first a couple of non-blockers from a spec review: 1. Group tags have not been required for some time. 2. Fedora 20 is the oldest supported release so the conditional really isn't needed, but if you're supporting older Fedora installations locally then let's keep it. One blocker from a spec review: Recently the use of the %license macro for marking what part of the documentation is the license became part of the packaging guidelines. Detailed review: There are some mixed licenses found by licensecheck but most of them don't look like they make it into the library or binaries so can be ignored. One I'm unsure of is the bundled boost headers. The readme in the include directory indicated they're used for the testsuite and don't make it into the binaries but mentions they could at a future date, however, grepping through the sources I'm not so sure that hasn't already happened: $ grep -r boost . | grep include ./engines/SoHeightMapToNormalMap.cpp:#include <boost/scoped_array.hpp> ./profiler/SoProfilingReportGenerator.cpp:#include <boost/scoped_array.hpp> ./profiler/SoScrollingGraphKit.cpp:#include <boost/scoped_ptr.hpp> ./profiler/SoScrollingGraphKit.cpp:#include <boost/scoped_array.hpp> ./profiler/SoScrollingGraphKit.cpp:#include <boost/intrusive_ptr.hpp> ./profiler/SoProfilerVisualizeKit.cpp:#include <boost/scoped_ptr.hpp> ./profiler/SoProfilerTopKit.cpp:#include <boost/intrusive_ptr.hpp> ./profiler/SoNodeVisualize.cpp:#include <boost/scoped_ptr.hpp> ./scxml/SoScXMLStateMachine.cpp:#include <boost/scoped_ptr.hpp> ./scxml/SoScXMLStateMachine.cpp:#include <boost/intrusive_ptr.hpp> ./scxml/ScXMLStateMachine.cpp:#include <boost/scoped_ptr.hpp> ./scxml/ScXMLState.cpp:#include <boost/scoped_ptr.hpp> ./scxml/ScXMLHistory.cpp:#include <boost/scoped_ptr.hpp> ./scxml/ScXMLInitial.cpp:#include <boost/scoped_ptr.hpp> ./coindefs.h:#include <boost/detail/workaround.hpp> /* For BOOST_WORKAROUND */ ./glue/dl.cpp: Boost. The boost headers can be found under \c include/ in the Coin ./actions/SoGLRenderAction.cpp:#include <boost/scoped_ptr.hpp> ./actions/SoGLRenderAction.cpp:#include <boost/scoped_array.hpp> ./xml/document.cpp:#include <boost/scoped_array.hpp> ./xml/document.cpp:#include <boost/scoped_array.hpp> ./nodes/SoVertexAttribute.cpp:#include <boost/scoped_ptr.hpp> ./navigation/SoScXMLRotateUtils.cpp:#include <boost/scoped_ptr.hpp> ./navigation/SoScXMLRotateUtils.cpp:#include <boost/intrusive_ptr.hpp> ./navigation/SoScXMLPanUtils.cpp://#include <boost/intrusive_ptr.hpp> ./navigation/SoScXMLSpinUtils.h:#include <boost/intrusive_ptr.hpp> Not all of those look like they're related to the testsuite but you're far more familiar with the package. Alternatively it looks like all of the include uses system include formatting instead of pointing specifically to the bundled ones so I wonder if we could add a BuildRequires for boost and rm -rf the bundled headers? -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review