[Bug 1194028] Review Request: python-jwt - JSON Web Token implementation in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1194028

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Ralph Bean from comment #4)
> New release here, addressing your concerns, except:
> 
> - The tests should show up in the next release.
Great.

> - I like shipping python2 and python3 versions of the executables for the
> purists out there that want to run python3-only everything.  :)  Other
> packages do this (in some cases its necessary like with nosetests-3.4 and
> coverage, other cases not, like python3-ansi2html).
I think this conflicts a bit with the intended switch to python 3. Right now
there's a separate executable for Python3, but the default is Python2. After
the switch, the default will be converted to Python3, but you still have
python3-jwt... It seems nicer to make /bin/jwt Python3 from the start.

Either way, this was just a suggestion.

> Koji scratch build: 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=9006048
> 
> Spec URL: http://threebean.org/rpm/SPECS/python-jwt.spec
> SRPM URL: http://threebean.org/rpm/SRPMS/python-jwt-0.4.3-1.fc21.src.rpm

- A dot is missing at the end of %description.

Rpmlint:
python-jwt.noarch: W: no-manual-page-for-binary jwt
python3-jwt.noarch: W: no-manual-page-for-binary python3-jwt

Only a missing dot. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]