https://bugzilla.redhat.com/show_bug.cgi?id=902086 --- Comment #129 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #126) > So... this is starting to look good. > > Add BR and R: java-base64 >= 2.3.8-7 > > Why this: > Requires(post): chkconfig > Requires(preun): chkconfig removed. I found in in some example.. > > Change systemd-units to systemd in the requirements. changed. > > Still valid: > > > - %description needs to be extended to say what this package does. > > The new text seems to have been pasted from a website. It's a promotional > > blurb. It even ends with "Learn more". > Please add something more technical. Improved by paragraph from wikipedia > > s/distributive search and analytic/distributed search and analytics/ > done > The daemon creates /data/elasticsearch. It should use /var/lib/elasticsearch > instead. used [1] > > The daemon should run under its own user. See > http://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation > for the setup. /var/lib/elasticsearch has to be owned by this user. > good catch! done. The user is never removed? directory also owned. > Updated service file in attachment. used with small sync from upstream service (https://jvanek.fedorapeople.org/elasticsearch/review/v6/elasticsearch.service.in) [1] This needed some rework. I had to get rid of %jpackage_script and use elasticsearch.in to This script is redirecting ES work to /var/lib/elasticsearch (in case of service) and to XDG_CONFIG_HOME in case od regular user's run My motivation is, that users data definitely should be separate from service's data. If one can use global data as default, he can always symlink. see: https://jvanek.fedorapeople.org/elasticsearch/review/v6/elasticsearch.in SPEC: https://jvanek.fedorapeople.org/elasticsearch/review/v6/elasticsearch.spec SRPM: https://jvanek.fedorapeople.org/elasticsearch/review/v6/elasticsearch-1.4.3-0.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review