https://bugzilla.redhat.com/show_bug.cgi?id=1194212 --- Comment #8 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Well, clearly nobody has ever really used the pkgconfig file we have been shipping with libuv, because it has been horribly broken for years! :-) (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #6) > The pkg-config file defines includedir, but doesn't pass it to the compiler. Fixed in libuv and compat-libuv010 dist-git. > There's an unexpanded %{git_snapshot} in the .pc file. This has potential to > break version queries. Fixed in both dist-gits as well. > Caution! The -devel package does not contain any *.so file, so one cannot > link with -luv as specified in $(pkg-config --libs). How is that supposed to > work? Yeah you need to pass the full name of the shared object in order to use this compat package. Fixed in compat-libuv010 dist-git. > Btw, typically the so-called "compat" packages are runtime only packages > with no -devel package to compile/link with. It would have been okay to name > it libuv010 and not use the compat- prefix. Is there any sort of guideline for this? I used the compat- prefix to signal to packagers of new libuv-using software that they really shouldn't be using this version. It only exists for one package in the repository and will be around only for Fedora 22 (and rawhide for a month or two). > Base library packages belong into group "System Environment/Libraries" for > many years. Their -devel packages belong into group "Development/Libraries". > The group tag is optional nowadays: > https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Fixed in both libuv and compat-libuv010. > Pkg-config are automatic these days. No need to explicit require "pkgconfig". Is this true for Fedora and RHEL>=5? I didn't drop it because it's harmless and I wasn't sure which branch might still need it... http://pkgs.fedoraproject.org/cgit/libuv.git/commit/?id=a2eeb8ee08266fad5eb5a8c458b16736b559e0db http://pkgs.fedoraproject.org/cgit/compat-libuv010.git/commit/?id=830dc4965b891728ac07cb108f423da5d6ee15f1 Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review