[Bug 1194212] Review Request: compat-libuv010 - Platform layer for node.js - compatibility library for nodejs 0.10.x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1194212



--- Comment #6 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
The pkg-config file defines includedir, but doesn't pass it to the compiler.

There's an unexpanded %{git_snapshot} in the .pc file. This has potential to
break version queries.

Caution! The -devel package does not contain any *.so file, so one cannot link
with -luv as specified in $(pkg-config --libs). How is that supposed to work?

Btw, typically the so-called "compat" packages are runtime only packages with
no -devel package to compile/link with. It would have been okay to name it
libuv010 and not use the compat- prefix.

Base library packages belong into group "System Environment/Libraries" for many
years. Their -devel packages belong into group "Development/Libraries". The
group tag is optional nowadays:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

Pkg-config are automatic these days. No need to explicit require "pkgconfig".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]