https://bugzilla.redhat.com/show_bug.cgi?id=1103414 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #8 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #5) > Looks like you forgot to build js-jquery1 (bug 1078371), so this package is > not yet installable. I rebuilt your js-jquery1 in a local mock and it seems > fine. Sorry, I'll build it ASAP. (Would have built it already, but dist-git seems to be down at the moment, even though I just used it an hour ago to update some existing packages...) > Two more questions: > > 1. Why are you rebuilding the provided scripts upon every new jquery1 > install instead of building them once at build time and adding strict > version dependencies? That would require rebuilding js-jquery-migrate on every js-jquery1 update. That's easy enough for me, but a provenpackager who updates js-jquery1 might not be aware of this strict dependency, until it breaks updates-testing that is. It also makes things more difficult for power users that might want to apply a patch to js-jquery1 or update it locally. It also makes downgrades more difficult for system administrators. By doing it this way, the concatenated copy always uses whatever version of js-jquery1 the system administrator wants to install with no hassle. If this required an actual build process with nodejs as the main jquery-migrate.js file does, I wouldn't have done it this way, as the extra dependencies would be unacceptable and make the package unavailable on arches that nodejs does not run on. But since we're just concatenating two text files with standard shell tools that are already installed, it seems nicer to defer it to install-time to allow end users and packagers both more flexibility. > 2. What are the missing dependencies required for %check? > > [...] > # missing dependencies > #%%check > #grunt > [...] npm(grunt-contrib-qunit) and its dependencies. This is now documented in the spec file. > Formally taking review. Thanks! -- Spec: https://patches.fedorapeople.org/jquery/js-jquery-migrate.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery-2.1.1-4.fc20.src.rpm * Thu Feb 19 2015 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 1.2.1-5 - document the postinstall scriptlets - indicate the missing dependencies for tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review