https://bugzilla.redhat.com/show_bug.cgi?id=1193842 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jstribny@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jstribny@xxxxxxxxxx --- Comment #1 from Josef Stribny <jstribny@xxxxxxxxxx> --- First of all; the package does not built. - state vagrant as build requirement as you need the vagrant macros Others: - missing upstream URL - wrong dependency on vagrant-libvirt - it does not depend on vagrant-libvirt at all - strange wording and typos - "Enables guests to have a registration capability, this is expecially useful on RHEL or SLES." could be "This Vagrant plugin enables guests to have a registration capability which is especially useful on RHEL or SLES." - README.md and CHANGELOG.md are not part of executable code so I would put them to %doc - misleading comment for check section "# Run the test suite" should be rather stating that we cannot run the test suite as it would require virtualization which is impossible in mock -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review