Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kflickr - an easy to use photo uploader for flickr written for KDE. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237355 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-05-15 01:24 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM - rpmlint is NOT silent RPM. + source files match upstream. cdda0c42b8e492a1c762014187dbfe63 kflickr-0.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text COPYING is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + scriptlets are used. + Provides: libkflickrpart.so + Requires: kdebase >= 3.4 libDCOP.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libkdecore.so.4 libkdeui.so.4 libkio.so.4 libkparts.so.2 libm.so.6 libqt-mt.so.3 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) + GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review