Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-IO-AIO - Asynchronous Input/Output https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239963 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-15 00:44 EST ------- For some reason the server at rubenkerkhof.com sends spec files with Content-Type: text/html, which makes it a bit more difficult than usual to inspect them. The package itself is fine. * source files match upstream: aa513866389ca768822ec2866500ccc2c85a7ce4f49a816be90e40d28f604259 IO-AIO-2.33.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream (COPYING file just says "same as Perl"). * latest version is being packaged. * BuildRequires are proper: As far as I know, the Test module is still in the base perl package. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: AIO.so()(64bit) perl(IO::AIO) = 2.33 perl-IO-AIO = 2.33-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(base) perl(strict) * %check is present and all tests pass: All tests successful. Files=8, Tests=63, 0 wallclock secs ( 0.17 cusr + 0.10 csys = 0.27 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review