[Bug 902086] Review request: Elasticsearch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=902086



--- Comment #77 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to gil cattaneo from comment #74)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #73)
> > - Consider removing explicit requires on jpackage-*. Dependency on
> > maven-local should add it automatically. Also there's no jpackage-tools
> > afaics.
> 
> Must removing all Requires, our maven tools autogenerate Requires list
Maybe the guidelines should be updated to be clearer. Maybe something like
"Packages using BR: maven-local" SHOULD NOT have explicit R: jpackage-utils or
R: java-headless" after the paragraph starting with "Java binary packages or
their dependencies MUST have Requires on ...".

(In reply to gil cattaneo from comment #75)
> Must removing these lines see above
> 
> mkdir $RPM_BUILD_ROOT/usr/share/java/
> # I'm not aware of any JNI being built
> mv $RPM_BUILD_ROOT/%{_jnidir}/elasticsearch.jar
> $RPM_BUILD_ROOT/%{_javadir}/elasticsearch.jar
> sed -i "s;%{_jnidir}/elasticsearch.jar;%{_javadir}/elasticsearch.jar;g"
> .mfiles
Even if it is a pure Java .jar file?

(In reply to gil cattaneo from comment #76)
> it would be better to upgrade elasticsearch to the latest stable version
> (1.4.3)
Definitely.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]