Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-JSON-XS - JSON serialising/deserialising, done correctly and fast Alias: perl-JSON-XS https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239973 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-14 21:44 EST ------- A clean package; The only question I have is why you didn't include the "eg" directory as documentation. I guess it only holds a benchmark. * source files match upstream: dc574ce851b8334d29dac844eec5a74b88f985c1b76e389a1e8a7407dd81c4b0 JSON-XS-1.21.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream (COPYING just says "same as Perl") * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: XS.so()(64bit) perl(JSON::XS) = 1.21 perl-JSON-XS = 1.21-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(strict) * %check is present and all tests pass: All tests successful. Files=16, Tests=24726, 4 wallclock secs ( 3.14 cusr + 0.23 csys = 3.37 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la droppings. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review