https://bugzilla.redhat.com/show_bug.cgi?id=974714 --- Comment #31 from Eric Griffith <EGriffith92@xxxxxxxxx> --- Created attachment 991607 --> https://bugzilla.redhat.com/attachment.cgi?id=991607&action=edit New spec file, please review. Disclaimer: First time writing a spec file, tried to follow all available guidelines. This builds, installs and works fine so i know this isn't broken just want to make it accurate as per guidelines & assumptions. A handful of questions in regards to the spec file format: 1) rpmlint complains about source0 not being a valid URL, but it rpmbuild can't find the source if I have it correct... see my above post in regards to that situation. 2) %build section. The original spec file had 'autoreconf' the compilation instructions had ./autogen.sh. Which is the correct one to use? Current spec uses autogen.sh 3) Is a "BuildRequires: systemd" necessary or is it just redundant? 4) Can someone link or explain the Requires(post)/(preun)/(postun), same with %post, %preun, %postun 5) %files does every single file need to be listed here or just 'important ones? I left out /usr/share/src, /usr/lib and a couple others. 6) Upstream name is "thermal_daemon" but I see it packaged elsewhere as "thermald" and the binary / .service is thermald. Preference goes to...? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review