https://bugzilla.redhat.com/show_bug.cgi?id=1190373 --- Comment #6 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- You are using conditional BuildRequires, which is OK so far: %if 0%{?with_python3} BuildRequires: python3-devel BuildRequires: python3-setuptools Requires: python3-requests %endif # with_python3 But in the appropriate %package section, you repeat them, which is confusing and redundant: %package -n python3-%{module} Summary: CLI for piping video streams to video players Group: Applications/Internet BuildArch: noarch BuildRequires: python3-setuptools BuildRequires: python3-requests Requires: fontawesome-fonts To make sure that the egg always gets build from source, remove the bundled version in src/. CFLAGS="$RPM_OPT_FLAGS" is superfluous for noarch packages. I'm missing CHANGELOG.rst and CONTRIBUTING.rst from %doc. The file requirements-docs.txt says that sphinx is needed to build the docs. Can't find this anywhere in the spec, and the folder docs/ in %doc is only a copy of the sources (including a Makefile!). This needs to be processed with python*-sphinx before it gets installed. The current content is unusable, for example we need index.html instead of index.rst to read the docs in a web browser, as intended. OK, let's run rpmlint on your packages anyway: $ rpmlint -i -v * python3-livestreamer.noarch: I: checking python3-livestreamer.noarch: I: checking-url http://livestreamer.tanuki.se/ (timeout 10 seconds) python3-livestreamer.noarch: W: no-manual-page-for-binary python3-livestreamer Each executable in standard binary directories should have a man page. python-livestreamer.noarch: I: checking python-livestreamer.noarch: I: checking-url http://livestreamer.tanuki.se/ (timeout 10 seconds) python-livestreamer.noarch: W: no-manual-page-for-binary livestreamer Each executable in standard binary directories should have a man page. python-livestreamer.src: I: checking python-livestreamer.src: I: checking-url http://livestreamer.tanuki.se/ (timeout 10 seconds) python-livestreamer.src: I: checking-url https://pypi.python.org/packages/source/l/livestreamer/livestreamer-1.11.1.tar.gz (timeout 10 seconds) python-livestreamer.spec: I: checking python-livestreamer.spec: I: checking-url https://pypi.python.org/packages/source/l/livestreamer/livestreamer-1.11.1.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 0 errors, 2 warnings. OK so far, rpmlint is quite silent. The missing man page is not up to you to fix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review