https://bugzilla.redhat.com/show_bug.cgi?id=1091659 --- Comment #25 from Christopher Meng <i@xxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #24) > However: > > Generally, when using sed substitutions, it is a good recommendation to add > guards to the spec file, which protect against sed failing to match. Either > before or after running sed. While applying a patch file would error out, if > it doesn't apply anymore, a failing sed match would cause the substitution > not to be applied. In this particular case, if the script contained anything > different from '#!/usr/bin/python\b' in line 1, e.g. /usr/bin/env something, > it would not be substituted. A guard would run "grep" on the file and ensure > that the sed match will be successful, e.g. an explicit "grep -m 1 > '^#!/usr/bin/python\b' || exit -1" would add safety for this particular case. I personally don't force people doing this since I believe people check the package in every update. But as you've said, it's worse to see the stillness when the hack doesn't work. So Dave here is your choice. This package is approved now. Feel free to request SCM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review