https://bugzilla.redhat.com/show_bug.cgi?id=1191808 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pingou@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- Just FYI: https://github.com/axiak/pyre2/issues/12 Something that might be worth considering to include: https://github.com/axiak/pyre2/pull/22 As for the review: * License is clean and compatible ! setup.py does not list python 2.7 ? Should we consider calling the package python2-re2 (as py3 is now around the corner)? * Spec is clean and understandable ? Why are the tests not running? ! You can consider drop the declaration of python2_sitelib since it's not used anywhere ! Beware that the last commit from upstream is from August 2013 * Builds fine on all arches on rawhide ! Fails to build locally from your src.rpm on F21: http://fpaste.org/184571/73139114/ (rpaths error) * sha512 src.rpm: b68c377df136c6d71f50f4dde1b6c0e3793838226d165dfd4c71760d12ca8c09fac37e0718903ff5fe4ff4ef3fc69126891cf819ecc7f6d7e26214f3076d0b74 ../SOURCES/re2-0.2.20.tar.gz * sha512 upstream: b68c377df136c6d71f50f4dde1b6c0e3793838226d165dfd4c71760d12ca8c09fac37e0718903ff5fe4ff4ef3fc69126891cf819ecc7f6d7e26214f3076d0b74 re2-0.2.20.tar.gz ! rpmlint (using the RPMs from koji): $ rpmlint python-re2-* python-re2.src: W: spelling-error %description -l en_US facebook's -> Facebook's, face book's, face-book's python-re2.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish python-re2.src: W: spelling-error %description -l en_US stdlib -> std lib, std-lib, stolid python-re2.x86_64: W: spelling-error %description -l en_US facebook's -> Facebook's, face book's, face-book's python-re2.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish python-re2.x86_64: W: spelling-error %description -l en_US stdlib -> std lib, std-lib, stolid python-re2.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/python2.7/site-packages/re2.so ['/usr/lib'] 3 packages and 0 specfiles checked; 1 errors, 6 warnings. That last error about rpath is annoying. I would like to get the build fixed on F21 and rpmlint cleared before approving this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review