[Bug 1091659] Review Request: iwyu - #include analysis tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1091659



--- Comment #23 from Dave Johansen <davejohansen@xxxxxxxxx> ---
> I think you should consult with upstream first. We should avoid using epoch tag in
> the SPEC if it's packaged with wrong version.

Upstream said that the version is 0.3 ( see
https://groups.google.com/forum/#!topic/include-what-you-use/dpVkAtWDyPM ) and
that's what "iywu --version" outputs, so I'll run with that.

> Did you check that the macro is correctly expanded by sed?

Yes, the macro is correctly expanded.

I believe that's all of the issues that have been brought up so far. The
updated .spec and source .rpm can be found at:
https://daveisfera.fedorapeople.org/iwyu_0.3/iwyu.spec
https://daveisfera.fedorapeople.org/iwyu_0.3/iwyu-0.3-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]