[Bug 1183286] Review Request: perl-Crypt-PWSafe3 - Read and write Passwordsafe v3 files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1183286



--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> ---
I don't like the dubious copyright statements in the source files here. 
Without reading the much clearer README file, these could give the impression
the code is licensed under Artistic (1.0) only.  That would be bad.  Perhaps
point it out to upstream?

Also, lib/Crypt/PWSafe3/Databaseformat.pm is licensed under Artistic 2.0. 
Update your License tag to reflect that.

Missing BR: Test::More, t/run.t:13

You could also add version constraints for Crypt::Random and Data::UUID.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]