https://bugzilla.redhat.com/show_bug.cgi?id=1183294 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 9c4280009001902966393372d06a657b0d239291791cdedd9a284a847fee2270). Ok. The patch is good. Ok Summary verified from lib/Compress/Snappy.pm. Ok. Description verified from lib/Compress/Snappy.pm. Ok. License verified from README, ppport.h, lib/Compress/Snappy.pm. Bundled csnappy code is not used. Ok. XS code is used. Architecture specific binary RPM is Ok. TODO: You can use plain `perl' commands instead of the `%{__perl}' macros. Bundled sources are removed before building. Ok. TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with `>= 6.52' (Makefile.PL:4). All tests pass. Ok. $ rpmlint perl-Compress-Snappy.spec ../SRPMS/perl-Compress-Snappy-0.23-1.fc22.src.rpm ../RPMS/x86_64/perl-Compress-Snappy-* perl-Compress-Snappy.src: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Compress-Snappy.src: W: spelling-error %description -l en_US de -> DE, ed, d perl-Compress-Snappy.x86_64: W: spelling-error Summary(en_US) de -> DE, ed, d perl-Compress-Snappy.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d 3 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm drwxr-xr-x 2 root root 0 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/Compress -rw-r--r-- 1 root root 4340 Feb 8 2014 /usr/lib64/perl5/vendor_perl/Compress/Snappy.pm drwxr-xr-x 2 root root 0 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/auto/Compress drwxr-xr-x 2 root root 0 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/auto/Compress/Snappy -rwxr-xr-x 1 root root 11160 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/auto/Compress/Snappy/Snappy.so drwxr-xr-x 2 root root 0 Feb 11 10:56 /usr/share/doc/perl-Compress-Snappy -rw-r--r-- 1 root root 3123 Feb 8 2014 /usr/share/doc/perl-Compress-Snappy/Changes -rw-r--r-- 1 root root 556 Feb 8 2014 /usr/share/doc/perl-Compress-Snappy/README drwxr-xr-x 2 root root 0 Feb 11 10:56 /usr/share/doc/perl-Compress-Snappy/ex -rw-r--r-- 1 root root 4242 Sep 11 2012 /usr/share/doc/perl-Compress-Snappy/ex/benchmark.pl -rw-r--r-- 1 root root 2710 Feb 11 10:56 /usr/share/man/man3/Compress::Snappy.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libcsnappy.so()(64bit) 1 libperl.so.5.20()(64bit) 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(Exporter) >= 5.57 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm | sort -f | uniq -c 1 perl(Compress::Snappy) = 0.23 1 perl-Compress-Snappy = 0.23-1.fc22 1 perl-Compress-Snappy(x86-64) = 0.23-1.fc22 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8893793). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review