https://bugzilla.redhat.com/show_bug.cgi?id=1189460 --- Comment #3 from Jiri Popelka <jpopelka@xxxxxxxxxx> --- s/%doc LICENSE/%license LICENSE/ Please comment (in spec) why /usr/share/dock/images/privileged-builder/docker.sh is not executable and why there's dock.tar.gz shipped ? (In reply to Tomas Tomecek from comment #2) > Spec and srpm updated. Next time please bump Release tag. > Added python 3 package partially ;-) You're missing: %prep %if 0%{?with_python3} rm -rf %{py3dir} cp -a . %{py3dir} find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|' %endif # with_python3 %build %if 0%{?with_python3} pushd %{py3dir} %{__python3} setup.py build popd %endif # with_python3 %install %if 0%{?with_python3} pushd %{py3dir} %{__python3} setup.py install --skip-build --root %{buildroot} popd %endif # with_python3 then use %{python2_sitelib} in %files and %{python2_sitelib} in %files -n python3-dock https://fedoraproject.org/wiki/Packaging:Python#Guidelines >(which may be problematic: there are no python 3 builds of GitPython and koji) Then don't define with_python3 until there are python3 versions of GitPython & koji. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review