[Bug 1187713] netty-tcnative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1187713



--- Comment #19 from jiri vanek <jvanek@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #18)
> (In reply to jiri vanek from comment #17)
> > (In reply to Zbigniew Jędrzejewski-Szmek from comment #16)
> > > The patch to load libraries is wrong. It makes the jar file architecture
> > > dependent,
> > yes, intentionally
> > 
> > > but it should not be. Just try loading from /usr/lib64, and then from
> > > /usr/lib.
> > > This will work on both 64 and 32 bit archs.
> > 
> > Well -  this patch is fedora only, and fedora do not support multilib jni
> > packages
> > (http://fedoraproject.org/wiki/Packaging:
> > Java#Packaging_JAR_files_that_use_JNI - uttermost end - ". Java packages
> > using JNI do not support multiarch installation."
> > 
> > Although I see your point, I would rather stay with my approach - to fail
> > immediately if wrong arch is found.
> > 
> > If you disagree, and insists, I will follow your opinion.
> I do disagree. It generates an unnecessary conflict (which is detected
> only during transaction check, which is nasty for users):
> 
> $ sudo dnf install results/netty-tcnative-1.1.30-0.fc22.x86_64.rpm
> ...
> Error: Transaction check error:
>   file /usr/lib/java/netty-tcnative/netty-tcnative.jar from install of
> netty-tcnative-1.1.30-0.fc22.x86_64 conflicts with file from package
> netty-tcnative-1.1.30-0.fc22.i686
>   file /usr/share/maven-metadata/netty-tcnative.xml from install of
> netty-tcnative-1.1.30-0.fc22.x86_64 conflicts with file from package
> netty-tcnative-1.1.30-0.fc22.i686
> 
...snip...
> > > This seems unnecessary.
> > This seems to be autoadded
> 
> -javadoc should be noarch! I think it might go away when the
> package is noarch.


javadoc made noarch.
spec:
https://jvanek.fedorapeople.org/elasticsearch/v4/netty-tcnative/netty-tcnative.spec
srpm:
https://jvanek.fedorapeople.org/elasticsearch/v4/netty-tcnative/netty-tcnative-1.1.30-0.fc21.src.rpm

Last thing we disagree is the arch/noarch lib/path/lib64 convention.

I'm still keeping my approach, beacuse I somehow feel that what you wont me to
do is wrong:

- from fedora guidelines the multilib jni packages are not supported
- my main package contains both jar and nativelib => not noarch

if I split natvie and java files to two packages and made jar "multilib"
(search in both lib and lib64) then yes, your case you shown with dnf will
work. However,
- the multilib is not supposed to be supported
- there is real danger that jar run in 64 jvm will load 32b library or vice
versa (afaik it is why jni is not supported multilib)
- the jar without so and vice versa dont have sense.

Thank you for patience!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]