[Bug 1091659] Review Request: iwyu - #include analysis tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1091659



--- Comment #21 from Christopher Meng <i@xxxxxxxx> ---
(In reply to Dave Johansen from comment #20)
> Additional Question:
> Currently, the version is set to 3.5 because that's what the tarball is
> called, but when you run "iwyu --version" it says 0.3 and I believe that's
> probably the more correct value. But when I change it, %setup chokes on the
> filename of the tar. Is there a way that I can get %setup to untar the file
> properly when I set the Version tag to 0.3?

"%setup -q" expanded as "%setup -q -n %{name}-%{version}", if you want to
specify the version in the top-level dir of the tarball, just change it to

%global real_version 0.3
%setup -q -n %{name}-%{real_version}

I checked the upstream yesterday, while they said the version is 0.3, their
tarball still contains 3.5. It's a bit confusing, but they might use 3.5 to
ease the pain of choosing the right version to use with different LLVM.

I think you should consult with upstream first. We should avoid using epoch tag
in the SPEC if it's packaged with wrong version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]