https://bugzilla.redhat.com/show_bug.cgi?id=1186819 --- Comment #7 from Andrew Niemantsverdriet <andrewniemants@xxxxxxxxx> --- (In reply to Pranav Kant from comment #5) > Few more things I found, that can be corrected in your SPEC file : > > - As according to this : > http://fedoraproject.org/wiki/Changes/ > Use_license_macro_in_RPMs_for_packages_in_Cloud_Image , the LICENSE file > should be moved from %doc to %license. > > - This is just a suggestion : you should list all the BuildRequires in > separate lines. It is easier to compare SPEC files this way. Eg: when a diff > between two spec files are done. > > - I can see your spec file contains a mixture of tabs and spaces. See the > Name: field and URL: field. It would be better if you untabify the file i.e > only use spaces to make it consistent. I have fixed the issues, there wasn't a mix of spaces, just an extra tab character. I also added the %licence macro that was new to me and split each BR to its own line. My updated files are located here: Spec URL: https://fedorapeople.org/~kaptk2/burp.spec SRPM URL: https://fedorapeople.org/~kaptk2/burp-1.3.48-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review