Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Gnome Network Monitor - A Network Monitor for the GNOME Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239435 ------- Additional Comments From jhrozek@xxxxxxxxxx 2007-05-14 05:19 EST ------- Jochen, thanks for a quick response! The updated packages are at: http://gnetworkmonitor.sourceforge.net/rpm/gnome-network-monitor.spec http://gnetworkmonitor.sourceforge.net/rpm/gnome-network-monitor-0.9-1.src.rpm 1) These were packaging bugs and were fixed. Thanks for pointing them out! >- Source0 contains not a full qualified URL. >- /usr/bin should be replace by %{_bindir} >- /usr/sbin should be replace by %{_sbindir} >- /ussr/share should be replace by %{_datadir} >- Rpmlint complaints binary package: >- Packages contains no docs. 2) I'm not sure I completely understand these comments: >- %{?_smp_mflags} missing on make without any comment. Does this flag make sense for a pure python package? I haven't seen it with other similar programs (I was largely inspired by system-config-* and setroubleshooter's spec files) > You can owned a whole directory, if the entry in the %file stanza end with a > slash 3) >- Package doesn't contain a verbatin copy of the license text Is this a requirement? The tarball contains license text. Not the RPM, but the specfile says it's GPL..is it really necessary to have a GPL text for every package on the system? 4) >- Programm crashed after startup: I filed your traceback as bug #1718208 at SF.net, it should be fixed now. Can you please re-try? Does it crash even if you select "Run unprivileged" from the usermode dialog Again, thanks for jumping on this review! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review