https://bugzilla.redhat.com/show_bug.cgi?id=1091659 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #18 from Christopher Meng <i@xxxxxxxx> --- Based on my previous review and static linking approval, this package should be approved as well. However I still give you some suggestions for this and hope you can fix these: 1. - cd build - make install DESTDIR=%{buildroot} - cp ../fix_includes.py %{buildroot}%{_bindir}/fix_includes + %make_install DESTDIR=%{buildroot} -C build + install -pDm755 fix_includes.py %{buildroot}%{_bindir}/fix_includes Use install -m will make sure its permission is correct. 2. Processing files: iwyu-3.5-1.fc22.i686 Provides: iwyu = 3.5-1.fc22 iwyu(x86-32) = 3.5-1.fc22 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.11) libc.so.6(GLIBC_2.15) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.2.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.6) libc.so.6(GLIBC_2.7) libdl.so.2 libdl.so.2(GLIBC_2.0) libform.so.5 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_3.4) libgcc_s.so.1(GLIBC_2.0) libm.so.6 libm.so.6(GLIBC_2.0) libncurses.so.5 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.2) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.8) libstdc++.so.6(GLIBCXX_3.4) libstdc++.so.6(GLIBCXX_3.4.11) libstdc++.so.6(GLIBCXX_3.4.15) libstdc++.so.6(GLIBCXX_3.4.20) libstdc++.so.6(GLIBCXX_3.4.9) libtinfo.so.5 libz.so.1 libz.so.1(ZLIB_1.2.0) rtld(GNU_HASH) Thus insert one line based on opinion 1: %make_install DESTDIR=%{buildroot} -C build + sed -i '1{\@^#!/usr/bin/python@s/^.*$/%{__python2}/}' fix_includes.py You may need BR: python2-devel because of that python2 macro, if you want it easier, just use /usr/bin/python2, but I don't think BR python2-devel is bad, though. This script doesn't support Python 3 certainly. 3. Drop Group tag. 4. ./run_iwyu_tests.py ./fix_includes_test.py You'd better use %{__python2} instead of directly execute it since I don't know the affection from Python 3 as default change in f22. 5. Consider virtual provides of that obtuse name: Provides: include-what-you-use = %{version}-%{release} Provides: include-what-you-use%{?_isa} = %{version}-%{release} 6. manpage can be ignored since help has been written into the python executables. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review