https://bugzilla.redhat.com/show_bug.cgi?id=1162234 --- Comment #18 from Parag AN(पराग) <panemade@xxxxxxxxx> --- I had a look at last updated srpm given comment#16. Here is my review 1) The rpmlint output is nss-securepass.x86_64: W: spurious-executable-perm /usr/share/doc/nss-securepass/LICENSE_APACHE2 nss-securepass.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/nss-securepass/LICENSE_APACHE2 nss-securepass.x86_64: W: spurious-executable-perm /usr/share/doc/nss-securepass/LICENSE_GNUGPL nss-securepass.x86_64: E: non-readable /etc/securepass.conf 0600L nss-securepass.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libnss_sp.so nss-securepass.x86_64: W: spurious-executable-perm /usr/share/doc/nss-securepass/LICENSE nss-securepass.x86_64: W: spurious-executable-perm /usr/share/doc/nss-securepass/LICENSE_MIT nss-securepass.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/nss-securepass/LICENSE_MIT 3 packages and 0 specfiles checked; 3 errors, 5 warnings. ==> See on how to fix wrong-script-end-of-line-encoding http://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings Then you definitely need to set license files permission to 644 as chmod 644 LICENSE LICENSE_APACHE2 LICENSE_GNUGPL LICENSE_MIT Then, in %files you are setting permission as non-readable file on /etc/securepass.conf which is not good. Remove %attr(0600,root,root) Any specific reason you want to set such a permission? Then, devel-file-in-non-devel-package message is okay as this is plugin. 2) macros definition are not followed. See http://fedoraproject.org/wiki/Packaging:RPMMacros Change mkdir -p %{buildroot}/etc to mkdir -p %{buildroot}%{_sysconfdir} 3) I see that Makefile.in already having rule to install files. Use that using make install DESTDIR=%{buildroot} INSTALL="install -p" but then this is failing as Makefile.in is having rule $(INSTALL) -o root -g root $(LIBNSS_SP) $(DESTDIR)/$(libdir)/$(LIBNSS_SP) we need to remove "-o root -g root" and installation will work. You can remove this in %prep as sed -i 's|-o root -g root||g' Makefile.in But then as there is no rule to install configuration file, let's keep existing installation of securepass.conf file. So your %install will look simple as %install make install DESTDIR=%{buildroot} INSTALL="install -p" mkdir -p %{buildroot}%{_sysconfdir} install -m 644 securepass.conf.template %{buildroot}/etc/securepass.conf 4) Group tag is not necessary now and can be removed. http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review