https://bugzilla.redhat.com/show_bug.cgi?id=1187869 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #4 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- $ rpmlint -i -v * kdocker.src: I: checking kdocker.src: W: spelling-error %description -l en_US openoffice -> open office, open-office, interoffice The value of this tag appears to be misspelled. Please double-check. kdocker.src: W: spelling-error %description -l en_US xmms -> Xmas The value of this tag appears to be misspelled. Please double-check. kdocker.src: W: spelling-error %description -l en_US firefox -> Firefox, firebox, fire fox The value of this tag appears to be misspelled. Please double-check. kdocker.src: I: checking-url https://launchpad.net/kdocker (timeout 10 seconds) kdocker.src:32: W: macro-in-comment %patch50 There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. kdocker.src:56: W: macro-in-comment %name There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. kdocker.src: W: patch-not-applied Patch50: kdocker-4.3-qmake_saner_defaults.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. kdocker.src: I: checking-url http://launchpad.net/kdocker/trunk/4.8/+download/kdocker-4.8.tar.gz (timeout 10 seconds) kdocker.x86_64: I: checking kdocker.x86_64: W: spelling-error %description -l en_US openoffice -> open office, open-office, interoffice The value of this tag appears to be misspelled. Please double-check. kdocker.x86_64: W: spelling-error %description -l en_US xmms -> Xmas The value of this tag appears to be misspelled. Please double-check. kdocker.x86_64: W: spelling-error %description -l en_US firefox -> Firefox, firebox, fire fox The value of this tag appears to be misspelled. Please double-check. kdocker.x86_64: I: checking-url https://launchpad.net/kdocker (timeout 10 seconds) kdocker.x86_64: E: incorrect-fsf-address /usr/share/licenses/kdocker/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/kdocker A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. kdocker-debuginfo.x86_64: I: checking kdocker-debuginfo.x86_64: I: checking-url https://launchpad.net/kdocker (timeout 10 seconds) kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/kdocker.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/xlibutil.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/xlibutil.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/trayitem.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/kdocker.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/trayitemmanager.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/trayitemmanager.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/trayitem.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/application.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/main.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/constants.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/constants.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/scanner.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/scanner.cpp The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/kdocker-4.8/src/application.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. kdocker.spec: I: checking kdocker.spec:32: W: macro-in-comment %patch50 There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. kdocker.spec:56: W: macro-in-comment %name There is a unescaped macro after a shell style comment in the specfile. Macros are expanded everywhere, so check if it can cause a problem in this case and escape the macro with another leading % if appropriate. kdocker.spec: W: patch-not-applied Patch50: kdocker-4.3-qmake_saner_defaults.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. kdocker.spec: I: checking-url http://launchpad.net/kdocker/trunk/4.8/+download/kdocker-4.8.tar.gz (timeout 10 seconds) 3 packages and 1 specfiles checked; 16 errors, 13 warnings. The incorrect FSF address has already been reported upstream, nothing to do. OK, a human reader knows why the patch is not applied, but to make rpmlint silent, you should also hash the line "Patch50:". Besides that, escape the % sign in patch0 with a second one (refers also to that one in %check). BuildRequires: /usr/bin/g++ First, g++ is part of the minimum build environment (through the package gcc-c++). Second, hardcoded paths in spec files are a bit unusual, unless it is impossible to use a macro, a package name etc. You can safely drop this requirement. %{_sysconfdir}/bash_completion.d/ This ownership is actually OK, I had a similar thing some time ago. But as far as I can remember, this directory wasn't owned by the "filesystem" package, but now it is: $ rpm -qf /etc/bash_completion.d lldpad-0.9.46-8.git48a5f38.fc21.x86_64 rpmdevtools-8.5-1.fc21.noarch fedpkg-1.19-1.fc21.noarch fcoe-utils-1.0.29-6.fc21.x86_64 udisks-1.0.4-15.fc21.x86_64 bash-completion-2.1-6.20141110git52d8316.fc21.noarch pulseaudio-5.0-25.fc21.x86_64 yum-utils-1.1.31-27.fc21.noarch filesystem-3.2-28.fc21.x86_64 bzr-2.6.0-6.fc21.x86_64 git-2.1.0-4.fc21.x86_64 That's why it is no longer needed to co-own it. Just add a * at the end. There's some problem with generating the man page, help2man produces unusable stuff: .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.46.4. .TH KDOCKER "1" "January 2015" "kdocker 4.8" "User Commands" .SH NAME kdocker \- manual page for kdocker 4.8 .SH DESCRIPTION kdocker: cannot connect to X server Obviously a running X-server is needed, that's strange. In any case worth to be reported upstream. As a workaround, you can generate the man page on your local system and add it manually to the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review