https://bugzilla.redhat.com/show_bug.cgi?id=1190060 --- Comment #2 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ---> Change spec like to fix: -Requires: %{name}-data%{?_isa} = %{version}-%{release} +Requires: %{name}-data = %{version}-%{release} - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in tanglet-data See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ---> Present %post, %postun and %posttrans *must* be run fpr the -data-subpkg instead of the main-pkg. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ---> '%license COPYING' is present in main-pkg, but missing from the subpkg. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 2 files have unknown license. ---> License-tag is fine. =) [!]: License file installed when any subpackage combination is installed. ---> see above. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/icons/hicolor/1024x1024/apps, /usr/share/icons/hicolor/1024x1024 [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/1024x1024/apps, /usr/share/icons/hicolor/1024x1024, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/scalable ---> -data-subpkg *must* 'Requires: hicolor-icon-theme'. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. ---> directory ownership, see above. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [!]: Package complies to the Packaging Guidelines ---> severe issues are present. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). ---> directory ownership, see above. [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in tanglet- data ---> false positive, not neccessary. [!]: Package functions as described. ---> icon-cache is not updated properly, see above. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint ---> package is not installable due to wrong requires, see above. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.5 starting (python version = 2.7.8)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.5 INFO: Mock Version: 1.2.5 Finish: chroot init INFO: installing package(s): /home/besser82/shared/fedora/review/1190060-tanglet/results/tanglet-1.3.1-1.fc22.x86_64.rpm /home/besser82/shared/fedora/review/1190060-tanglet/results/tanglet-data-1.3.1-1.fc22.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/yum --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 22 install /home/besser82/shared/fedora/review/1190060-tanglet/results/tanglet-1.3.1-1.fc22.x86_64.rpm /home/besser82/shared/fedora/review/1190060-tanglet/results/tanglet-data-1.3.1-1.fc22.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: tanglet-1.3.1-1.fc22.x86_64.rpm tanglet-data-1.3.1-1.fc22.noarch.rpm tanglet-1.3.1-1.fc22.src.rpm tanglet.x86_64: W: spelling-error %description -l de single -> Single, singe, -single tanglet.x86_64: W: spelling-error %description -l de player -> Player, -player tanglet.x86_64: W: spelling-error %description -l de word -> Word, wird, -word tanglet.x86_64: W: spelling-error %description -l de finding -> findig, Einding, Findling tanglet.x86_64: W: spelling-error %description -l de game -> gare, Same, Name tanglet.x86_64: W: spelling-error %description -l de based -> Base tanglet.x86_64: W: spelling-error %description -l de on -> in, ob, von tanglet.x86_64: W: spelling-error %description -l de The -> Theo, Tee, Ehe tanglet.x86_64: W: spelling-error %description -l de object -> Objekt tanglet.x86_64: W: spelling-error %description -l de of -> oft, Hof, oh tanglet.x86_64: W: spelling-error %description -l de the -> ehe, tue, Ehe tanglet.x86_64: W: spelling-error %description -l de is -> iss, ins, ist tanglet.x86_64: W: spelling-error %description -l de to -> tot, eo, so tanglet.x86_64: W: spelling-error %description -l de list -> liest, List, lost tanglet.x86_64: W: spelling-error %description -l de as -> ad, ans, als tanglet.x86_64: W: spelling-error %description -l de many -> man tanglet.x86_64: W: spelling-error %description -l de words -> Lords, Mords, Bords tanglet.x86_64: W: spelling-error %description -l de you -> YouTube tanglet.x86_64: W: spelling-error %description -l de can -> van, an, ran tanglet.x86_64: W: spelling-error %description -l de before -> Befolger tanglet.x86_64: W: spelling-error %description -l de time -> Mime, intime, stimme tanglet.x86_64: W: spelling-error %description -l de runs -> rund, uns, Suns tanglet.x86_64: W: spelling-error %description -l de out -> tut, gut, oft tanglet.x86_64: W: spelling-error %description -l de There -> Therme, These, Tiere tanglet.x86_64: W: spelling-error %description -l de are -> rare, arte, arge tanglet.x86_64: W: spelling-error %description -l de several -> veralber tanglet.x86_64: W: spelling-error %description -l de timer -> Eimer, Stimmer, Metier tanglet.x86_64: W: spelling-error %description -l de modes -> müdes, Todes, Codes tanglet.x86_64: W: spelling-error %description -l de that -> tat, hat, trat tanglet.x86_64: W: spelling-error %description -l de determine -> determiniere, Determinante, Termine tanglet.x86_64: W: spelling-error %description -l de how -> Show, hol, hoc tanglet.x86_64: W: spelling-error %description -l de much -> mich, euch, such tanglet.x86_64: W: spelling-error %description -l de start -> Start, statt, starr tanglet.x86_64: W: spelling-error %description -l de with -> wich, Witz tanglet.x86_64: W: spelling-error %description -l de and -> ans, an, ad tanglet.x86_64: W: spelling-error %description -l de if -> in, im, Riff tanglet.x86_64: W: spelling-error %description -l de get -> geht, et, gebt tanglet.x86_64: W: spelling-error %description -l de when -> wen, wehen, Ehen tanglet.x86_64: W: spelling-error %description -l de find -> finde, feind, sind tanglet.x86_64: W: spelling-error %description -l de You -> YouTube tanglet.x86_64: W: spelling-error %description -l de join -> Jogging tanglet.x86_64: W: spelling-error %description -l de letters -> Letters, Retters, Vetters tanglet.x86_64: W: spelling-error %description -l de horizontally -> horizontal tanglet.x86_64: W: spelling-error %description -l de vertically -> vertikal tanglet.x86_64: W: spelling-error %description -l de or -> vor, Tor, er tanglet.x86_64: W: spelling-error %description -l de diagonally -> diagonal tanglet.x86_64: W: spelling-error %description -l de any -> an, ans, Andy tanglet.x86_64: W: spelling-error %description -l de direction -> Direktion, Indirektion tanglet.x86_64: W: spelling-error %description -l de make -> mache, male, hake tanglet.x86_64: W: spelling-error %description -l de long -> log, lang, Song tanglet.x86_64: W: spelling-error %description -l de next -> nett, hext, Text tanglet.x86_64: W: spelling-error %description -l de each -> wach, ach, eich tanglet.x86_64: W: spelling-error %description -l de other -> Äther, Herodot tanglet.x86_64: W: spelling-error %description -l de board -> Keyboard tanglet.x86_64: W: spelling-error %description -l de However -> Verwehre tanglet.x86_64: W: spelling-error %description -l de not -> Not, bot, not- tanglet.x86_64: W: spelling-error %description -l de reuse -> reise, reuelose tanglet.x86_64: W: spelling-error %description -l de same -> Same, -same, samt tanglet.x86_64: W: spelling-error %description -l de letter -> Letter, kletter, letzter tanglet.x86_64: W: spelling-error %description -l de cells -> Dells, Fells, Celles tanglet.x86_64: W: spelling-error %description -l de must -> musst, muss, just tanglet.x86_64: W: spelling-error %description -l de be -> bei, übe, je tanglet.x86_64: W: spelling-error %description -l de at -> AT, ad, tat tanglet.x86_64: W: spelling-error %description -l de three -> ehrte, Therese tanglet.x86_64: W: spelling-error %description -l de four -> Tour, Fourier tanglet.x86_64: W: spelling-error %description -l de large -> lagre, karge, arge tanglet-data.noarch: W: no-documentation tanglet.src: W: spelling-error %description -l de single -> Single, singe, -single tanglet.src: W: spelling-error %description -l de player -> Player, -player tanglet.src: W: spelling-error %description -l de word -> Word, wird, -word tanglet.src: W: spelling-error %description -l de finding -> findig, Einding, Findling tanglet.src: W: spelling-error %description -l de game -> gare, Same, Name tanglet.src: W: spelling-error %description -l de based -> Base tanglet.src: W: spelling-error %description -l de on -> in, ob, von tanglet.src: W: spelling-error %description -l de The -> Theo, Tee, Ehe tanglet.src: W: spelling-error %description -l de object -> Objekt tanglet.src: W: spelling-error %description -l de of -> oft, Hof, oh tanglet.src: W: spelling-error %description -l de the -> ehe, tue, Ehe tanglet.src: W: spelling-error %description -l de is -> iss, ins, ist tanglet.src: W: spelling-error %description -l de to -> tot, eo, so tanglet.src: W: spelling-error %description -l de list -> liest, List, lost tanglet.src: W: spelling-error %description -l de as -> ad, ans, als tanglet.src: W: spelling-error %description -l de many -> man tanglet.src: W: spelling-error %description -l de words -> Lords, Mords, Bords tanglet.src: W: spelling-error %description -l de you -> YouTube tanglet.src: W: spelling-error %description -l de can -> van, an, ran tanglet.src: W: spelling-error %description -l de before -> Befolger tanglet.src: W: spelling-error %description -l de time -> Mime, intime, stimme tanglet.src: W: spelling-error %description -l de runs -> rund, uns, Suns tanglet.src: W: spelling-error %description -l de out -> tut, gut, oft tanglet.src: W: spelling-error %description -l de There -> Therme, These, Tiere tanglet.src: W: spelling-error %description -l de are -> rare, arte, arge tanglet.src: W: spelling-error %description -l de several -> veralber tanglet.src: W: spelling-error %description -l de timer -> Eimer, Stimmer, Metier tanglet.src: W: spelling-error %description -l de modes -> müdes, Todes, Codes tanglet.src: W: spelling-error %description -l de that -> tat, hat, trat tanglet.src: W: spelling-error %description -l de determine -> determiniere, Determinante, Termine tanglet.src: W: spelling-error %description -l de how -> Show, hol, hoc tanglet.src: W: spelling-error %description -l de much -> mich, euch, such tanglet.src: W: spelling-error %description -l de start -> Start, statt, starr tanglet.src: W: spelling-error %description -l de with -> wich, Witz tanglet.src: W: spelling-error %description -l de and -> ans, an, ad tanglet.src: W: spelling-error %description -l de if -> in, im, Riff tanglet.src: W: spelling-error %description -l de get -> geht, et, gebt tanglet.src: W: spelling-error %description -l de when -> wen, wehen, Ehen tanglet.src: W: spelling-error %description -l de find -> finde, feind, sind tanglet.src: W: spelling-error %description -l de You -> YouTube tanglet.src: W: spelling-error %description -l de join -> Jogging tanglet.src: W: spelling-error %description -l de letters -> Letters, Retters, Vetters tanglet.src: W: spelling-error %description -l de horizontally -> horizontal tanglet.src: W: spelling-error %description -l de vertically -> vertikal tanglet.src: W: spelling-error %description -l de or -> vor, Tor, er tanglet.src: W: spelling-error %description -l de diagonally -> diagonal tanglet.src: W: spelling-error %description -l de any -> an, ans, Andy tanglet.src: W: spelling-error %description -l de direction -> Direktion, Indirektion tanglet.src: W: spelling-error %description -l de make -> mache, male, hake tanglet.src: W: spelling-error %description -l de long -> log, lang, Song tanglet.src: W: spelling-error %description -l de next -> nett, hext, Text tanglet.src: W: spelling-error %description -l de each -> wach, ach, eich tanglet.src: W: spelling-error %description -l de other -> Äther, Herodot tanglet.src: W: spelling-error %description -l de board -> Keyboard tanglet.src: W: spelling-error %description -l de However -> Verwehre tanglet.src: W: spelling-error %description -l de not -> Not, bot, not- tanglet.src: W: spelling-error %description -l de reuse -> reise, reuelose tanglet.src: W: spelling-error %description -l de same -> Same, -same, samt tanglet.src: W: spelling-error %description -l de letter -> Letter, kletter, letzter tanglet.src: W: spelling-error %description -l de cells -> Dells, Fells, Celles tanglet.src: W: spelling-error %description -l de must -> musst, muss, just tanglet.src: W: spelling-error %description -l de be -> bei, übe, je tanglet.src: W: spelling-error %description -l de at -> AT, ad, tat tanglet.src: W: spelling-error %description -l de three -> ehrte, Therese tanglet.src: W: spelling-error %description -l de four -> Tour, Fourier tanglet.src: W: spelling-error %description -l de large -> lagre, karge, arge 3 packages and 0 specfiles checked; 0 errors, 133 warnings. Requires -------- tanglet-data (rpmlib, GLIBC filtered): tanglet (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Gui.so.5()(64bit) libQt5Widgets.so.5()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) tanglet-data(x86-64) Provides -------- tanglet-data: tanglet-data tanglet: appdata() appdata(tanglet.appdata.xml) application() application(tanglet.desktop) tanglet tanglet(x86-64) Source checksums ---------------- http://gottcode.org/tanglet/tanglet-1.3.1-src.tar.bz2 : CHECKSUM(SHA256) this package : d0eab174eaa8cdd5f3499ae275db4cd720172ef28346273db7f5988f2304e0d8 CHECKSUM(SHA256) upstream package : d0eab174eaa8cdd5f3499ae275db4cd720172ef28346273db7f5988f2304e0d8 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1190060 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== Solution ===== NOT approved! Please fix those errors and I'll have another look. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review