[Bug 1177019] Review Request: os-net-config - Host network configuration tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1177019

Ben Nemec <bnemec@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(bnemec@xxxxxxxxxx |
                   |)                           |



--- Comment #3 from Ben Nemec <bnemec@xxxxxxxxxx> ---
Thanks for the reviews guys.

https://fedorapeople.org/~bnemec/os-net-config.spec
https://fedorapeople.org/~bnemec/os-net-config-0.1.1-2.fc21.src.rpm

-Removed unnecessary systemd requires
-Fixed tab/spaces mismatch
-Build and include docs in the package
-Removed the delorean changelog entry

I did not remove the egg-info files because none of our other OpenStack
packages seem to be doing that and we appear to be regenerating them at build
time anyway.  Also, I think the prohibition around egg files is for egg
packages, whereas we've just got egg metadata.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]