https://bugzilla.redhat.com/show_bug.cgi?id=1107800 --- Comment #8 from Dave Love <d.love@xxxxxxxxxxxxxxx> --- (In reply to Orion Poplawski from comment #7) > - Bundled jar/class files should be removed before build Done. > - Drop %defattr(), no even needed in EL5. Done. It was there through following the instructions to use the template. Does it do any harm? > - Need to use %optflags in build. Done (sigh). That requirement seems particularly unfortunate for high-performance numerical code. > - Last changelog entry has name "root" Very odd. Fixed, thanks. > - GUI needs a .desktop file Done as best I can tell. I don't think I could find any instructions originally. > - Use %{?_isa} in Requires. Done, but could confuse a stupid person, since the packages I looked at originally didn't have it, and I don't remember seeing it in the instructions. > - Note: Invalid buildroot found: > %{_tmppath}/%name-%{version}-%{release}-root-%(%{__id_u} -n) > See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag I don't understand why, but I've changed it to the preferred form. > - I don't think you need to duplicate the main description in all of the > sub-packages > - Use %global I'm confused as I thought that's what I had done. It's a pity fedora-review doesn't work in EPEL. Updates: SRPM: https://loveshack.fedorapeople.org/review/dl_poly-1.9.20140324-5.el6.src.rpm SPEC: https://loveshack.fedorapeople.org/review/dl_poly.spec http://copr.fedoraproject.org/coprs/loveshack/livhpc/build/70718/ has been pending a few hours, but I mocked the above OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review