Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-ncurses - A module for ruby applications for using ncurses interfaces https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239954 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-05-13 12:30 EST ------- Well, for 1.1-2: * parallel make and fedora specific compilation flags - Supporting parallel make is needed when possible (please check: the section "Parallel make" of: http://fedoraproject.org/wiki/Packaging/Guidelines ) - For ruby, fedora specific compilation flags seems to be used automatically, however IMO using these flags explicitly is recommended. Because of the reasons above, please use for make line: ----------------------------------------------------- make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS -fPIC" ----------------------------------------------------- * Timestamp - For files which are not built or modified during rebuild, keeping timestamps on those files is recommended. To keep timestamp, the following method works for this package. ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------ * debuginfo permission - The created debuginfo rpms bears the following rpmlint: ------------------------------------------------------- W: ruby-ncurses-debuginfo spurious-executable-perm /usr/src/debug/ncurses-ruby-1.1/ncurses_wrap.c -------------------------------------------------------- This means that the permission of this file (ncursrs_wrap.c) is incorrect. Fix the permission of this file to 0644 (i.e. add the following to %prep stage:) -------------------------------------------------------- chmod 0644 ncurses_wrap.c --------------------------------------------------------- * License - License text and the source files actually say that this is licensed under LGPL, not GPL * Documentation - Please add "THANKS" to %doc - Please consider examples/ directory to %doc (in that case, you have to change the permission of all files under examples/ directory to 0644). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review