https://bugzilla.redhat.com/show_bug.cgi?id=1190056 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@xxxxx Flags| |needinfo?(lkundrak@xxxxx) --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok 043ace59a061a99fff2757a17be4e1d6 kgraphviewer-2.2.0.tar.xz licensing: ok macros: ok scripotlets: NOT ok 1. MUST fix icon ownership and add missing iconcache scriptlets change %{_kde4_iconsdir}/hicolor to %{_kde4_iconsdir}/hicolor/*/*/* and add icon scriptlets per: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets?rd=Packaging/ScriptletSnippets#Icon_Cache 2. main pkg MUST have tighter dependency on libs, replace Requires: %{name}-libs = %{version} with Requires: %{name}-libs%{?_isa} = %{version}-%{release} 3. -devel dependencies are wrong MUST fix, %{_isa} is in the wrong place. Requires: kgraphviewer = %{version}-%{release}%{?isa} Requires: %{name}-libs = %{version}-%{release}%{?isa} I'd suggest: Requires: %{name}-libs%{?_isa} = %{version}-%{release} (and skip the dependency on the main pkg) 4. SHOULD improve kde-related dependencies, replace BuildRequires: qt-devel BuildRequires: kdelibs-devel Requires: kde-filesystem with BuildRequires: kdelibs4-devel %{?kde_runtime_requires} (in main pkg) 5. SHOULD build out-of-src tree, replace %cmake_kde4 . make %{?_smp_mflags} ... make install DESTDIR={%buildroot} with (something like): %build mkdir %{_target_platform} pushd %{_target_platform} %{cmake_kde4} .. popd make %{?_smp_mflags} -C %{_target_platform} ... make install/fast DESTDIR=%{buildroot} -C %{_target_platform} 6. SHOULD omit deprecated rpm tags, like: Group: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review