https://bugzilla.redhat.com/show_bug.cgi?id=1176595 --- Comment #8 from Dave Love <d.love@xxxxxxxxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #7) > > In %files section, %defattr is not needed unless you are changing default permission > > Explained here: > https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions Unfortunately I followed the instructions to use the template, and I thought that was required for EPEL5. I'll remove them. > > Also, its good to give successful scratch build link of package in koji Why does it need to be in koji, and not copr? As far as I know, koji doesn't allow you to build a chain of things, which is what I need, and I'm sure I've seen others supplying copr builds. > Running "fedora-review -b 1176595" would be a great idea. Unfortunately it doesn't work on RHEL6. > It's not a simple package, so there are quite some things to check, such as > the dependency filtering. What's wrong with that? I'm mostly interested in domain experts checking it, though I've built other things against it. (I'm not sure I have the energy to pursue getting packages in, but I'd like to find problems and prevent people duplicating the work.) > And the base package dependencies of all subpackages: > > | %package devel > | Summary: Development files for %name > | Requires: hypre = %{version} > > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Omitting the release looks like a mistake, thanks. I don't remember the _isa requirement being in the instructions when I originally read them, and it definitely wasn't in spec files I'd looked at/copied. Also the instructions imply in the "Requires" section that it's only relevant for -devel packages if you don't read the rest. Not arguing, of course, just explaining why contributors may be confused. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review