https://bugzilla.redhat.com/show_bug.cgi?id=1188625 --- Comment #2 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files need to be in -devel subpackage. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Unversioned shared objects need to be in -devel subpackage (see above) - Multiple binaries are using rpath. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath - When installing new shared libraries, %post must call ldconfig See: https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries - Package bundles a very old version of zlib with known security issues Package also bundles numerous other libraries such as bzip. Please remove any potentially bundled code during %prep so that it's clear that it isn't being compiled in. See: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries - The CPL license does not cover all of the sources in the package. Some parts are BSD, EPL, others. - The tarball includes license texts, but they are not included in the package with %license - The main ast package must own its directories. - The package is not built with the standard Fedora compiler flags as far as I can tell from the build script. - For directories you reference in many places in the spec (like /usr/ast/bin), please create a %global macro and use that, in case it is ever changed. ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [X]: Package does not contain any libtool archives (.la) Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "CDDL", "Unknown or generated", "*No copyright* BSD", "zlib/libpng", "BSD (3 clause)", "BSD (2 clause)". 2084 files have unknown license. Detailed output of licensecheck in /dev/shm/1188625-astutils/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/ast, /usr/ast/bin, /usr/include/ast [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/ast, /usr/ast/bin, /usr/include/ast [!]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [X]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. Note: Test run failed [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [X]: Packages must not store files under /srv, /opt or /usr/local Note: Test run failed [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: astutils-20141224-1.fc22.x86_64.rpm astutils-20141224-1.fc22.src.rpm astutils.x86_64: W: spelling-error Summary(en_US) toolchain -> tool chain, tool-chain, Chaitin astutils.x86_64: W: spelling-error %description -l en_US cdt -> CDT, ct, cit astutils.x86_64: W: spelling-error %description -l en_US dss -> dz, dds, doss astutils.x86_64: W: spelling-error %description -l en_US nmake -> make, unmake, n make astutils.x86_64: W: spelling-error %description -l en_US sfio -> Fiona astutils.x86_64: W: spelling-error %description -l en_US vcodex -> codex, v codex, code astutils.x86_64: W: spelling-error %description -l en_US vmalloc -> mallow astutils.x86_64: E: binary-or-shlib-defines-rpath /bin/coshell ['$ORIGIN/../lib'] astutils.x86_64: E: missing-call-to-setgroups-before-setuid /bin/coshell astutils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/xgrep ['$ORIGIN/../lib'] astutils.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/xgrep astutils.x86_64: E: binary-or-shlib-defines-rpath /usr/ast/bin/pax ['$ORIGIN/../lib'] astutils.x86_64: E: missing-call-to-setgroups-before-setuid /usr/ast/bin/pax astutils.x86_64: E: missing-call-to-setgroups-before-setuid /lib64/libshell.so.1 astutils.x86_64: E: binary-or-shlib-defines-rpath /usr/ast/bin/sort ['$ORIGIN/../lib'] astutils.x86_64: E: missing-call-to-setgroups-before-setuid /usr/ast/bin/sort astutils.x86_64: E: missing-call-to-setgroups-before-setuid /lib64/libast.so.1 astutils.x86_64: E: binary-or-shlib-defines-rpath /usr/ast/bin/mailx ['$ORIGIN/../lib'] astutils.x86_64: E: missing-call-to-setgroups-before-setuid /usr/ast/bin/mailx astutils.x86_64: E: missing-call-to-setgroups-before-setuid /lib64/libdll.so.1 astutils.x86_64: E: binary-or-shlib-defines-rpath /usr/ast/bin/sed ['$ORIGIN/../lib'] astutils.x86_64: E: missing-call-to-setgroups-before-setuid /usr/ast/bin/sed astutils.x86_64: E: missing-call-to-setgroups-before-setuid /lib64/libsum.so.1 astutils.x86_64: E: missing-call-to-setgroups-before-setuid /lib64/libcoshell.so.1 astutils.x86_64: E: missing-call-to-setgroups-before-setuid /lib64/libcmd.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /lib64/libcmd.so astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/recsort.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/bzlib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/stk.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/error.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/tag.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/pt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_dir.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/int.3ast.gz 55: warning: macro `LI' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/fs3d.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_limits.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sfio_t.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/update.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/debug.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/tok.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/prototyped.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/dss.h astutils.x86_64: W: devel-file-in-non-devel-package /lib64/libshell.so astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/modex.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_stdio.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_botch.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/exparse.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sum.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/nval.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/preroot.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vcrdb.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/expr.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cs.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/mime.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_getopt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/mc.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/usage.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vctable.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/history.h astutils.x86_64: E: zero-length /usr/include/ast/pp.yacc astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/fts.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sfdcbzip.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vcodex.h astutils.x86_64: W: devel-file-in-non-devel-package /lib64/libast.so astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ardir.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/wordexp.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/dirent.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_ioctl.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/align.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/modecanon.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_socket.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cmdlist.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_ndbm.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_std.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_windows.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ssexit.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/nl_types.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/namval.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/getopt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_vfork.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_mmap.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_intercept.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/endian.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_cs.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/fnmatch.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/tar.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/strton.3ast.gz 77: warning: can't find special character `le' astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/tm.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vdb.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sfdcgzip.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vecargs.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/bgp.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vclib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_api.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/path.3ast.gz 233: warning: macro `LI' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/css.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/mnt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_dirent.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_float.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/coshell.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/pp.3ast.gz 56: warning: macro `}S' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vdelta.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vmalloc.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_aso.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/fnv.h astutils.x86_64: W: non-conffile-in-etc /etc/binfmt.d/shbinexec.conf astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/dt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ivmethods.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/shcmd.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ppkey.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_nl_types.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ftw.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/find.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/recfmt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ftwalk.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/tv.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/shellapi.h astutils.x86_64: W: devel-file-in-non-devel-package /lib64/libcoshell.so astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ls.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/aso.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_sizeof.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/re_comp.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ptv.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/coshell.3ast.gz 53: warning: macro `}S' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/regex.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/nvapi.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vcwindow.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/magicid.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/wctype.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/paxlib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_tty.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cmdext.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/shell.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/pp.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/stack.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vgraph.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/swap.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/times.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/hashkey.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cs_lib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/dsslib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_wctype.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cmdarg.h astutils.x86_64: E: postin-without-ldconfig /lib64/libshell.so.1 astutils.x86_64: E: postun-without-ldconfig /lib64/libshell.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_lib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cmd.h astutils.x86_64: W: devel-file-in-non-devel-package /lib64/libsum.so astutils.x86_64: W: manual-page-warning /usr/share/man/man3/magic.3ast.gz 234: warning: macro `LI' not defined astutils.x86_64: E: postin-without-ldconfig /lib64/libast.so.1 astutils.x86_64: E: postun-without-ldconfig /lib64/libast.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/wait.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_errorf.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_param.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sfio_s.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vcmethods.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_fddir.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cxlib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_namval.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/pzip.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_time.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_sys.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/wchar.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/modecanon.3ast.gz 100: warning: macro `LI' not defined astutils.x86_64: W: devel-file-in-non-devel-package /lib64/libdll.so astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/uu.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_standards.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/lc.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sig.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/bytesex.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/hashpart.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ccode.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/regexp.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vcsfio.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sys/socket.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast.h astutils.x86_64: E: postin-without-ldconfig /lib64/libdll.so.1 astutils.x86_64: E: postun-without-ldconfig /lib64/libdll.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/dlldefs.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_ccode.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/stak.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_map.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_wait.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cx.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sfdisc.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/iv.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_wchar.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/proc.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_common.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/re.3ast.gz 163: warning: macro `LI' not defined astutils.x86_64: E: zero-length /usr/include/ast/ppkey.yacc astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_mode.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/iblocks.3ast.gz 59: warning: macro `LI' not defined astutils.x86_64: E: postin-without-ldconfig /lib64/libsum.so.1 astutils.x86_64: E: postun-without-ldconfig /lib64/libsum.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cdt.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_fcntl.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/zlib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/iconv.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/option.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/msg.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/magic.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/cs.3ast.gz 57: warning: macro `}S' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/mam.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/pzip.3ast.gz 304: warning: macro `}S' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ip6.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/stdio.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/jcl.h astutils.x86_64: E: postin-without-ldconfig /lib64/libcoshell.so.1 astutils.x86_64: E: postun-without-ldconfig /lib64/libcoshell.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/codex.h astutils.x86_64: W: manual-page-warning /usr/share/man/man3/ptv.3ast.gz 63: warning: macro `L' not defined astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/vccrypto.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/cdtlib.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_fs.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_debug.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/fv.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/tmx.h astutils.x86_64: E: postin-without-ldconfig /lib64/libcmd.so.1 astutils.x86_64: E: postun-without-ldconfig /lib64/libcmd.so.1 astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/glob.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/ast_iconv.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/sfio.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/hash.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/zconf.h astutils.x86_64: W: devel-file-in-non-devel-package /usr/include/ast/netflow.h astutils.x86_64: W: no-manual-page-for-binary msgget astutils.x86_64: W: no-manual-page-for-binary msgadmin astutils.x86_64: W: no-manual-page-for-binary xgrep astutils.x86_64: W: no-manual-page-for-binary msgcvt astutils.x86_64: W: no-manual-page-for-binary msggen astutils.x86_64: W: non-standard-dir-in-usr ast astutils.src: W: spelling-error Summary(en_US) toolchain -> tool chain, tool-chain, Chaitin astutils.src: W: spelling-error %description -l en_US cdt -> CDT, ct, cit astutils.src: W: spelling-error %description -l en_US dss -> dz, dds, doss astutils.src: W: spelling-error %description -l en_US nmake -> make, unmake, n make astutils.src: W: spelling-error %description -l en_US pax -> pa, ax, pas astutils.src: W: spelling-error %description -l en_US sfio -> Fiona astutils.src: W: spelling-error %description -l en_US vcodex -> codex, v codex, code astutils.src: W: spelling-error %description -l en_US vmalloc -> mallow astutils.src:103: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 103) astutils.src: W: invalid-url Source1: INIT.2014-12-24.tgz astutils.src: W: invalid-url Source0: ast-open.2014-12-24.tgz 2 packages and 0 specfiles checked; 32 errors, 211 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- astutils (rpmlib, GLIBC filtered): /bin/sh coreutils diffutils glibc-common grep ld-linux-x86-64.so.2()(64bit) libast.so.1()(64bit) libc.so.6()(64bit) libcmd.so.1()(64bit) libcoshell.so.1()(64bit) libdl.so.2()(64bit) libdll.so.1()(64bit) libm.so.6()(64bit) libnsl.so.1()(64bit) libshell.so.1()(64bit) libsum.so.1()(64bit) libutil.so.1()(64bit) rtld(GNU_HASH) systemd-units Provides -------- astutils: astutils astutils(x86-64) libast.so.1()(64bit) libcmd.so.1()(64bit) libcoshell.so.1()(64bit) libdll.so.1()(64bit) libshell.so.1()(64bit) libsum.so.1()(64bit) Unversioned so-files -------------------- astutils: /lib64/libast.so astutils: /lib64/libcmd.so astutils: /lib64/libcoshell.so astutils: /lib64/libdll.so astutils: /lib64/libshell.so astutils: /lib64/libsum.so Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1188625 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review