https://bugzilla.redhat.com/show_bug.cgi?id=1098807 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> --- Review: - License ok - rpmlint output ok: $ rpmlint /home/tomspur/rpmbuild/SRPMS/python3-liblarch-3.0-1.gitb873698.fc21.src.rpm /home/tomspur/rpmbuild/RPMS/noarch/python3-liblarch-3.0-1.gitb873698.fc21.noarch.rpm /home/tomspur/rpmbuild/RPMS/noarch/python3-liblarch_gtk-3.0-1.gitb873698.fc21.noarch.rpm python3-liblarch.src: W: spelling-error %description -l en_US acyclic -> cyclic, a cyclic, acyclovir python3-liblarch.src:11: W: macro-in-comment %{version} python3-liblarch.noarch: W: spelling-error %description -l en_US acyclic -> cyclic, a cyclic, acyclovir python3-liblarch_gtk.noarch: W: spelling-error Summary(en_US) Liblarch -> Lib larch, Lib-larch, Oligarch python3-liblarch_gtk.noarch: W: spelling-error Summary(en_US) gtk -> gt, gt k python3-liblarch_gtk.noarch: W: spelling-error Summary(en_US) Treeview -> Tree view, Tree-view, Preview python3-liblarch_gtk.noarch: W: spelling-error %description -l en_US liblarch -> lib larch, lib-larch, oligarch python3-liblarch_gtk.noarch: W: spelling-error %description -l en_US gtk -> gt, gt k python3-liblarch_gtk.noarch: W: spelling-error %description -l en_US Treeview -> Tree view, Tree-view, Preview 3 packages and 0 specfiles checked; 0 errors, 9 warnings. - source matches upstream - version ok - BR/R ok Issues: - Please query upstream to also tag a 3.0 release, so you don't need to checkout a commit after 3.0 to get it. - Please run the testsuite with xvfb. The diff is: --- python3-liblarch.spec.orig 2015-02-04 00:04:39.891570620 +0100 +++ python3-liblarch.spec 2015-02-04 00:12:02.053702707 +0100 @@ -13,6 +13,7 @@ BuildArch: noarch BuildRequires: python3-devel +BuildRequires: xorg-x11-server-Xvfb Requires: pygobject3 %description @@ -36,9 +37,8 @@ %install %{__python3} setup.py install --skip-build --root %{buildroot} -#tests require DISPLAY -#check -#make test +%check +xvfb-run make test %files %doc AUTHORS LICENSE README.md examples Note, that I'd prefer to run "%{_bindir}/nosetests-3.? -v", instead of the non-verbose nose run above. - The _gtk package requires the base package, so you don't need to have an extra %doc. - Please use %license for the LICENSE file: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review