https://bugzilla.redhat.com/show_bug.cgi?id=1180723 --- Comment #19 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Well, * Files listed twice ------------------------------------------ warning: File listed twice: /etc/clufter/bash-completion warning: File listed twice: /usr/share/bash-completion/completions/clufter warning: File listed twice: /usr/share/doc/clufter-0.3.6a-git.e88876e/fdl-1.3.txt warning: File listed twice: /usr/share/doc/clufter-0.3.6a-git.e88876e/gpl-2.0.txt ------------------------------------------ * Directory ownership - /usr/share/bash-completion/ is not owned unless you install bash-completion Other things: * Redundant requires - "Requires: filesystem" is not needed. * Redundant %doc - Again files / directories under /usr/share/doc is automatically marked as %doc and redundant %doc for %{_defaultdocdir}/%{name}-XXX should be removed. * Source using git - Please follow http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release - Write how to create the source tarball - It is advised to include date in release number when using snapshot. * Scriptlet error ---------------------------------------------- $ sudo rpm -ivh clufter-lib-general-0.3.6-0.3.a_git.e88876e.fc21.noarch.rpm Preparing... ################################# [100%] Updating / installing... 1:clufter-lib-general-0.3.6-0.3.a_g################################# [100%] /var/tmp/rpm-tmp.BSuniD: line 5: syntax error near unexpected token `&&' /var/tmp/rpm-tmp.BSuniD: line 5: ` && /usr/bin/clufter --completion-bash > "${bashcomp}" 2>/dev/null || :' warning: %post(clufter-lib-general-0.3.6-0.3.a_git.e88876e.fc21.noarch) scriptlet failed, exit status 2 ---------------------------------------------- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review