[Bug 1181927] Review Request: python3-mwparserfromhell - A parser for MediaWiki wikicode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1181927

Pranav Kant <pranav913@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pranav913@xxxxxxxxx



--- Comment #3 from Pranav Kant <pranav913@xxxxxxxxx> ---
This is an unofficial review.

Please consider fixing following issues.

- Please use %license for your LICENSE file. Licenses should be cloud-safe.
See : https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
See : 
http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image

- Permissions on files are not set properly. Permission on executables should
be 0755, yours are 0775. See rpmlint output below.


RPMLINT OUTPUT 
------
Checking: python3-mwparserfromhell-0.3.3-1.fc21.x86_64.rpm
          python3-mwparserfromhell-0.3.3-1.fc21.src.rpm
python3-mwparserfromhell.x86_64: W: spelling-error Summary(en_US) wikicode ->
wiki code, wiki-code, Unicode
python3-mwparserfromhell.x86_64: W: spelling-error %description -l en_US
wikicode -> wiki code, wiki-code, Unicode
python3-mwparserfromhell.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.4/site-packages/mwparserfromhell/parser/_tokenizer.cpython-34m.so
0775L
python3-mwparserfromhell.src: W: spelling-error Summary(en_US) wikicode -> wiki
code, wiki-code, Unicode
python3-mwparserfromhell.src: W: spelling-error %description -l en_US wikicode
-> wiki code, wiki-code, Unicode
2 packages and 0 specfiles checked; 1 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]