[Bug 1188372] Review Request: kate5 - Advanced Text Editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1188372

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m



--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
$ rpmlint -i -v *
kate5.src: I: checking
kate5.src: I: checking-url
https://projects.kde.org/projects/kde/applications/kate (timeout 10 seconds)
kate5.src:52: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

kate5.src:52: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

kate5.src:52: W: macro-in-comment %{release}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

kate5.src: I: checking-url
http://download.kde.org/stable/applications/14.12.1/src/kate-14.12.1.tar.xz
(timeout 10 seconds)
kate5.x86_64: I: checking
kate5.x86_64: I: checking-url
https://projects.kde.org/projects/kde/applications/kate (timeout 10 seconds)
kate5.x86_64: E: invalid-soname /usr/lib64/libkdeinit5_kate.so
libkdeinit5_kate.so
The soname of the library is neither of the form lib<libname>.so.<major> or
lib<libname>-<major>.so.

kate5.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/kate.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kate5-debuginfo.x86_64: I: checking
kate5-debuginfo.x86_64: I: checking-url
https://projects.kde.org/projects/kde/applications/kate (timeout 10 seconds)
kate5-plugins.x86_64: I: checking
kate5-plugins.x86_64: I: checking-url
https://projects.kde.org/projects/kde/applications/kate (timeout 10 seconds)
kate5-plugins.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kate5.spec: I: checking
kate5.spec:52: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

kate5.spec:52: W: macro-in-comment %{version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

kate5.spec:52: W: macro-in-comment %{release}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

kate5.spec: I: checking-url
http://download.kde.org/stable/applications/14.12.1/src/kate-14.12.1.tar.xz
(timeout 10 seconds)
kwrite.x86_64: I: checking
kwrite.x86_64: I: checking-url
https://projects.kde.org/projects/kde/applications/kate (timeout 10 seconds)
kwrite.x86_64: E: invalid-soname /usr/lib64/libkdeinit5_kwrite.so
libkdeinit5_kwrite.so
The soname of the library is neither of the form lib<libname>.so.<major> or
lib<libname>-<major>.so.

kwrite.x86_64: W: shared-lib-calls-exit /usr/lib64/libkdeinit5_kwrite.so
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

kwrite.x86_64: W: no-manual-page-for-binary kwrite
Each executable in standard binary directories should have a man page.

5 packages and 1 specfiles checked; 2 errors, 10 warnings.


Regarding the macro-in-comment warnings, the verbose rpmlint output says it all
what to do.


The invalid-soname error messages need to be addressed. There's nothing
comparable in the kate-4* package.

$ rpm -qp --provides kate5-14.12.1-1.fc22.x86_64.rpm
application()
application(org.kde.kate.desktop)
config(kate5) = 14.12.1-1.fc22
kate = 14.12.1-1.fc22
kate5 = 14.12.1-1.fc22
kate5(x86-64) = 14.12.1-1.fc22
libkdeinit5_kate.so()(64bit)
mimehandler(text/plain)

Maybe it is needed to filter it out of the Provides?


The exit() call is not that critical, as far as I know, but maybe should be
reported upstream.

The gzipped icons and missing man page can be ignored for the time being.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]