https://bugzilla.redhat.com/show_bug.cgi?id=1182761 MartinKG <mgansser@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #6 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Golo Fuchert from comment #5) > Martin, the package is already in a very good shape. There is only one thing > that has to be changed before including it in the repos: > Surely you are aware of the latest changes to the Packaging Guidelines that > the license files should not be included as %doc any longer, but as %license > (see > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Text). Please change that before pushing the > package to the repos. done > Additionally, but that is only a matter of taste, I am not so happy with the > frequent explicit mentioning of the package name in the spec file due to the > mismatch of the package name and the source name. Maybe you want to consider > introducing additional macro names. done @Golo Thanks for the review. Spec URL: https://www.dropbox.com/s/a5r0ymwnafz2xw6/vdr-weatherforecast.spec?dl=0 SRPM URL: https://www.dropbox.com/s/6i3b0w5q8byz1sw/vdr-weatherforecast-0.0.2-2.fc21.src.rpm?dl=0 %changelog * Mon Feb 02 2015 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.0.2-2 - Mark license files as %%license where available - Defined global macro pname for program name -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review