Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: agistudio - AGI integrated development environment https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239811 lxtnow@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From lxtnow@xxxxxxxxx 2007-05-12 21:49 EST ------- Well, ----------------- %install section ----------------- cp help/* %{buildroot}%{_datadir}/agistudio/help cp -r template/* %{buildroot}%{_datadir}/agistudio/template -------------------------------------------------------------------- You SHOULD keep timstamps on template and help files (included sub-directories) and paste right permission on them, so the use of 'install [option]' is more suitable, just like below: install -p -m 0664 help/* %{buildroot}%{_datadir}/agistudio/help install -p -m 0664 template/* %{buildroot}%{_datadir}/agistudio/template ------------------------------------------------------- install -m 755 -d template %{buildroot}%{_datadir}/agistudio/template install -m 755 -d help %{buildroot}%{_datadir}/agistudio/help Those above can be improved : install -D (or mkdir -p) %{buildroot}%{_datadir}/agistudio/template install -D (or mkdir -p) %{buildroot}%{_datadir}/agistudio/help --------------------------------------------------------------- cp -a src/app_icon.xpm %{buildroot}%{_datadir}/icons/hicolor/32x32/apps/%{name}.xpm Use 'install -p -m 0664' instead of 'cp -a' the use of -a option isn't necessary (is the same as -dpR where not really needded) ------------------- >From %files section -------------------- i think that the help files should be installed in /usr/share/doc/[package_name] sub-directory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review