Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-places-plugin - Places menu for the Xfce panel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238349 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxx 2007-05-12 19:50 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License(GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: fc9828001674e7428ef4023e4a320c87 xfce4-places-plugin-0.2.0.tar.bz2 fc9828001674e7428ef4023e4a320c87 xfce4-places-plugin-0.2.0.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Same minor non blocking comment about the Requires for xfce4-panel being 4.4.0. If we know we are building against 4.4.1, shouldn't we require that? Shouldn't matter much however. I see no blockers, this package is APPROVED. Don't forget to close this review request once it's been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review