https://bugzilla.redhat.com/show_bug.cgi?id=1187713 --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Remove dot from summary. BuildRequires: java-devel should not be needed. ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: make tar See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 In principle this could be removed, but is allowed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/maven-poms/netty-tcnative, /usr/lib/java/netty-tcnative [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven-poms/netty- tcnative, /usr/lib/java/netty-tcnative Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Please remove. [x]: Javadoc documentation files are generated and included in -javadoc subpackage Yes. [x]: Javadoc subpackages should not have Requires: jpackage-utils This should be fixed. [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/netty/netty- tcnative/releases/tag/netty-tcnative-1.1.30.Fork2.tar.gz This link does not work. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). No, see above. [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in netty- tcnative-javadoc OK. Java: [ ]: Packages are noarch unless they use JNI Note: netty-tcnative subpackage is not noarch. Please verify manually Should be noarch. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2396160 bytes in /usr/share Rpmlint ------- Checking: netty-tcnative-1.1.30-0.fc22.x86_64.rpm netty-tcnative-javadoc-1.1.30-0.fc22.x86_64.rpm netty-tcnative-1.1.30-0.fc22.src.rpm netty-tcnative.x86_64: W: summary-ended-with-dot C Netty-tcnative is a fork of Tomcat Native. Should be fixed. netty-tcnative.x86_64: W: name-repeated-in-summary C Netty-tcnative Should be fixed. netty-tcnative.x86_64: W: spelling-error %description -l en_US mavenization -> magnetization, humanization, maximization netty-tcnative.x86_64: W: incoherent-version-in-changelog 1.1.30.Fork2.0 ['1.1.30-0.fc22', '1.1.30-0'] Should be fixed. netty-tcnative.x86_64: E: no-binary netty-tcnative.x86_64: W: only-non-binary-in-usr-lib netty-tcnative.x86_64: W: no-documentation netty-tcnative.src: W: summary-ended-with-dot C Netty-tcnative is a fork of Tomcat Native. netty-tcnative.src: W: name-repeated-in-summary C Netty-tcnative netty-tcnative.src: W: spelling-error %description -l en_US mavenization -> magnetization, humanization, maximization netty-tcnative.src: W: strange-permission netty-tcnative-1.1.30.Fork2.tar.gz 0640L netty-tcnative.src: W: invalid-url Source0: https://github.com/netty/netty-tcnative/releases/tag/netty-tcnative-1.1.30.Fork2.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Diff spec file in url and in SRPM --------------------------------- --- /var/tmp/1187713-netty-tcnative/srpm/netty-tcnative.spec 2015-01-30 13:38:39.140804828 -0500 +++ /var/tmp/1187713-netty-tcnative/srpm-unpacked/netty-tcnative.spec 2015-01-29 10:33:27.000000000 -0500 @@ -10,8 +10,4 @@ Source0: https://github.com/netty/netty-tcnative/releases/tag/%{name}-%{namedversion}.tar.gz -#dont know how to configure requires, just guessing -Requires: java-headless -Requires: apr -Requires: openssl BuildRequires: maven-local @@ -25,8 +21,7 @@ BuildRequires: openssl-devel BuildRequires: java-devel -BuildRequires: maven-hawtjni-plugin #parent pom is needed BuildRequires: netty - +BuildRequires: maven-hawtjni-plugin %description Requires -------- netty-tcnative (rpmlib, GLIBC filtered): java-headless jpackage-utils netty-tcnative-javadoc (rpmlib, GLIBC filtered): jpackage-utils Should be removed. Provides -------- netty-tcnative: mvn(io.netty:netty-tcnative) mvn(io.netty:netty-tcnative:pom:) netty-tcnative netty-tcnative(x86-64) osgi(io.netty.tcnative) netty-tcnative-javadoc: netty-tcnative-javadoc netty-tcnative-javadoc(x86-64) Should be noarch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review