[Bug 1187232] Review Request: perl-inc-latest - Use modules bundled in inc/ if they are newer than installed ones

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1187232



--- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Changes in the SPEC file:

--- perl-inc-latest.spec.old    2015-01-29 16:27:35.000000000 +0100
+++ perl-inc-latest.spec        2015-01-30 13:41:48.000000000 +0100
@@ -11,17 +11,11 @@
 BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.17
 BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
-# Run-time
-BuildRequires:  perl(Carp)
-BuildRequires:  perl(ExtUtils::Installed)
-BuildRequires:  perl(File::Basename)
-BuildRequires:  perl(File::Copy)
-BuildRequires:  perl(File::Path)
-BuildRequires:  perl(File::Spec)
-BuildRequires:  perl(IO::File)
 # Tests
 BuildRequires:  perl(Test::More)
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
+Requires:       perl(ExtUtils::Installed)
+Conflicts:      perl-Module-Build < 2:0.42.10-4

 %description
 The inc::latest module helps bootstrap configure-time dependencies for CPAN
@@ -44,7 +38,8 @@
 make test

 %files
-%doc Changes LICENSE README
+%license LICENSE
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*


All tests pass. Ok.

$ rpmlint  perl-inc-latest.spec ../SRPMS/perl-inc-latest-0.500-1.fc22.src.rpm
../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

> FIX: Package LICENSE file using %license macro.
-%doc Changes LICENSE README
+%license LICENSE
+%doc Changes README
Ok.

> FIX: Do not build-require run-requires because there the only tests which
> exists does not compile nor run the code.
-# Run-time
-BuildRequires:  perl(Carp)
-BuildRequires:  perl(ExtUtils::Installed)
-BuildRequires:  perl(File::Basename)
-BuildRequires:  perl(File::Copy)
-BuildRequires:  perl(File::Path)
-BuildRequires:  perl(File::Spec)
-BuildRequires:  perl(IO::File)

FIX: Build-require perl(File::Spec) used by tests (t/00-report-prereqs.t:11).

> FIX: Run-requires `perl(ExtUtils::Installed)' (lib/inc/latest.pm:88).
$ rpm -q --requires -p ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm |
sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Carp)
      1 perl(ExtUtils::Installed)
      1 perl(File::Basename)
      1 perl(File::Copy)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(inc::latest::private)
      1 perl(IO::File)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Ok.

> FIX: Conflict with perl-Module-Build-2:0.42.10-3.fc22 and older because both
> packages installs files into the same location.
$ rpm -q --conflicts -p ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm
| sort -f | uniq -c
      1 perl-Module-Build < 2:0.42.10-4
Ok.

Package build in F22
(http://koji.fedoraproject.org/koji/taskinfo?taskID=8782458). Ok.

# LANG=en_US.UTF-8 yum --enablerepo=f22-build install
~test/rpmbuild/RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm 
Loaded plugins: auto-update-debuginfo
Examining
/home/test/rpmbuild/RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm:
perl-inc-latest-0.500-1.fc22.noarch
/home/test/rpmbuild/RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm: does
not update installed package.
Error: Nothing to do

TODO: I recommend to increase release number, otherwise it will clash with
current perl-Module-Build.spec's sub-package.

Please correct all `FIX' items, consider fixing `TODO' items, and provide new
spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]