https://bugzilla.redhat.com/show_bug.cgi?id=1187232 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: daa905f363c6a748deb7c408473870563fcac79b9e3e95b26e130a4a8dc3c611). Ok. License verified from README, LICENSE, lib/inc/latest.pm, lib/inc/latest/private.pm. Ok. Summary verified from README. Ok. Description verified from README. Ok. No XS code. noarch BuildArch is Ok. FIX: Package LICENSE file using %license macro. vars (lib/inc/latest.pm:56) not used when when running tests. Ok. FIX: Do not build-require run-requires because there the only tests which exists does not compile nor run the code. CPAN::Meta::Prereqs nor CPAN::Meta are not needed for tests. Ok. All tests pass. Ok. $ rpmlint perl-inc-latest.spec ../SRPMS/perl-inc-latest-0.500-1.fc22.src.rpm ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jan 30 10:15 /usr/share/doc/perl-inc-latest -rw-r--r-- 1 root root 151 Dec 6 05:43 /usr/share/doc/perl-inc-latest/Changes -rw-r--r-- 1 root root 11500 Dec 6 05:43 /usr/share/doc/perl-inc-latest/LICENSE -rw-r--r-- 1 root root 6272 Dec 6 05:43 /usr/share/doc/perl-inc-latest/README -rw-r--r-- 1 root root 3760 Jan 30 10:15 /usr/share/man/man3/inc::latest.3pm.gz -rw-r--r-- 1 root root 1388 Jan 30 10:15 /usr/share/man/man3/inc::latest::private.3pm.gz drwxr-xr-x 2 root root 0 Jan 30 10:15 /usr/share/perl5/vendor_perl/inc drwxr-xr-x 2 root root 0 Jan 30 10:15 /usr/share/perl5/vendor_perl/inc/latest -rw-r--r-- 1 root root 9698 Dec 6 05:43 /usr/share/perl5/vendor_perl/inc/latest.pm -rw-r--r-- 1 root root 3086 Dec 6 05:43 /usr/share/perl5/vendor_perl/inc/latest/private.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(Carp) 1 perl(File::Basename) 1 perl(File::Copy) 1 perl(File::Path) 1 perl(File::Spec) 1 perl(inc::latest::private) 1 perl(IO::File) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-requires `perl(ExtUtils::Installed)' (lib/inc/latest.pm:88). $ rpm -q --provides -p ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(inc::latest) = 0.500 1 perl(inc::latest::private) = 0.500 1 perl-inc-latest = 0.500-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. # LANG=en_US.UTF-8 yum install ~test/rpmbuild/RPMS/noarch/perl-inc-latest-0.500-1.fc22.noarch.rpm [...] Transaction check error: file /usr/share/man/man3/inc::latest.3pm.gz from install of perl-inc-latest-0.500-1.fc22.noarch conflicts with file from package perl-Module-Build-2:0.42.10-3.fc22.noarch file /usr/share/perl5/vendor_perl/inc/latest.pm from install of perl-inc-latest-0.500-1.fc22.noarch conflicts with file from package perl-Module-Build-2:0.42.10-3.fc22.noarch file /usr/share/perl5/vendor_perl/inc/latest/private.pm from install of perl-inc-latest-0.500-1.fc22.noarch conflicts with file from package perl-Module-Build-2:0.42.10-3.fc22.noarch FIX: Conflict with perl-Module-Build-2:0.42.10-3.fc22 and older because both packages installs files into the same location. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8780808). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items and provide new SPEC file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review