[Bug 1185019] Review Request: gap-pkg-tomlib - GAP Table of Marks package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1185019

Jerry James <loganjerry@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #9 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> It's recommended to use %{_smp_mflags}. This allows the number of threads to
> be overridden if necessary:
> 
>   parallel %{?_smp_mflags} --no-notice gzip -1 ::: data/*.tom

Ah, good solution.  I will make that change.

> Is the license specified anywhere upstream?

A few versions ago, there was nothing about the license anywhere in the
distribution.  I wrote to Liam Naughton, one of the upstream developers, as
follows:

"Hello Liam,

I am working on adding GAP and some of its packages to the Fedora
Linux distribution.  However, I don't see any indication of the
license under which TomLib is distributed.  Did you intend it to have
the same license as GAP itself, namely GPL version 2 or any later
version?  If so, would you mind adding a statement about the license
to the TomLib web site or, even better, to the tar file itself?"

He responded as follows:

"Hi Jerry,

I've added a copyright notice to the tomlib homepage and to the manual. We
adopt the same copyright notice as GAP.

All the best

Liam"

And indeed, you can now see the sentence "We adopt the copyright regulations of
GAP as detailed in the copyright notice in the GAP manual." on
http://schmidt.nuigalway.ie/tomlib/ and in several files in doc/.  The manual
is included in the gap-online-help package, or you can view the copyright
section online here:

http://www.gap-system.org/Manuals/doc/ref/chap1.html#X7950EFA183E3F666

where you can see that it indicates GPLv2+ as the license.  That is much more
roundabout than I would prefer, but that's the story.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #8)
> One more question: why /usr/lib/gap/pkg and not /usr/share/something? Is the
> place upstream expects?

Yes, it is.  Even though most GAP add-on packages are noarch, some (such as
gap-pkg-io and gap-pkg-browse) have binary components.  Therefore, /usr/share
seems inappropriate for those packages.  However, they can't be multiarch,
since they depend on the gap binary, so there is no need to put them in
%{_libdir} either.  Hence, they go into /usr/lib, thereby allowing the noarch
packages to remain noarch.

Here is the version using %{?_smp_mflags}:
Spec URL: https://jjames.fedorapeople.org/gap-pkg-tomlib/gap-pkg-tomlib.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-tomlib/gap-pkg-tomlib-1.2.5-3.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]