[Bug 1171260] Review Request: rubygem-jmespath - JMESPath - Ruby Edition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1171260



--- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> ---
(In reply to Mamoru TASAKA from comment #2)
> For 1.0.2-1:
> 
> Well, very simple package. Now a few questions.
> 
> * BR: rubygem(simplecov)
>   - Is this BR needed? (any coverage tests?)
> 

Yes, it looks like simplecov is not really needed, although it needs to remove
some 4 lines:

sed -i spec/compliance_spec.rb spec/spec_helper.rb -e '/simplecov\|SimpleCov/d'

> * Tweaking multi_json dependency
>   - does not seem to be working. Please check this.
>     (and is this needed?)
> 

Nice catch! Removed. I misread the '~> 1.0' string.

> * %setup - unpacking %{SOURCE1}
> ----------------------------------------------------
> %setup -q -D -T -n  %{gem_name}-%{version}
> tar -xzf %{SOURCE1}
> ----------------------------------------------------
>   - "%setup -q -D -T -n  %{gem_name}-%{version} -a 1" is more smart.

OK, '-a 1' will be better.


New version:

Spec URL:
http://scientific.zcu.cz/fedora/rubygem-jmespath-1.0.2-2/rubygem-jmespath.spec
SRPM URL:
http://scientific.zcu.cz/fedora/rubygem-jmespath-1.0.2-2/rubygem-jmespath-1.0.2-2.fc22.src.rpm

Thu Jan 29 2015 František Dvořák <valtri@xxxxxxxxxx> - 1.0.2-2
- Removed rubygem(simplecov) BR
- Cleanups

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]