[Bug 1186889] Review Request: geoipupdate - decouple update utility from GeoIP as per upstream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1186889

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
This in not EPEL material, you can drop the compat cruft:

  # Noarch subpackages available from Fedora 10, RHEL 6
  %global noarch_subpkgs 0%{?fedora} > 9 || 0%{?rhel} > 5

  rm -rf %{buildroot}

Something strange happens with the provides:
  Provides:       %{name}-cron = %{version}-%{release}
  Obsoletes:      %{name}-cron < %{version}-%{release}
This is implied, no need to add it.

There's no need to talk about non-Linux (or even non-Fedora) in the package
description. Remove "Currently the program only supports Linux and
other Unix- like systems."

Also, you don't need to copy ${SOURCE1} twice. Just install it directly in
%install.

Otherwise looks OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]